search

ampproject / ampstart

AMP Start source code and templates .
https://ampstart.com/
Apache License 2.0
418 stars 151 forks source link

[Land and See] Tap targets are too small of Menu, X, and <>'s on mobile #737

Closed spacedino closed 6 years ago

spacedino commented 7 years ago

Current Tap targets are too small to consistently hit every time.

Should be All tap targets should be a min of 40px40px around the icon. For the carousel images, if a user taps the 30% to the right and 30% to the left can we trigger the advance in that direction?

afilbert commented 6 years ago

Thanks for the direction. Will address in my next PR.

afilbert commented 6 years ago

Ok, I addressed the tap target to be 40px/40px. The 30% might be a good suggestion for future amp-carousel enhancements.

spacedino commented 6 years ago

@afilbert thank you! yea that's a really good idea - we should just bake that in.