ampproject / ampstart

AMP Start source code and templates .
https://ampstart.com/
Apache License 2.0
419 stars 152 forks source link

[Land and See] Loader - turn off default 3 dot loader #765

Closed spacedino closed 6 years ago

spacedino commented 6 years ago

Turn off the 3 dot loader can be over written with "no loading" attribute. https://www.ampproject.org/docs/reference/common_attributes#noloading

(The custom loader you have is great so we don't need the default loader. It's too much on slow networks).

ask @camelburrito if you have an issue with this one - he things its an easy and quick fix.

afilbert commented 6 years ago

Thanks for the feedback @spacedino, can you clarify which controls the default 3 dot loader should be turned off for? Is there an ampstart-specific custom loader that you're referring to? cc @camelburrito

720 looks like it could be a duplicate.

camelburrito commented 6 years ago

I think she means you can turn it off in places where you have a placeholder that serves a similar purpose. (gray background on the home page).

No, there is no ampstart specific custom loader.

spacedino commented 6 years ago

yes correct, this is a dupe. sorry will close!

spacedino commented 6 years ago

actually @camelburrito , i'm still seeing it in places like here...its particularly confusing because it looks like the carousel UI. @aghassemi - when we change the loader will it apply to components already implement?

screen shot 2017-11-20 at 4 48 53 pm
camelburrito commented 6 years ago

So the easy fix here is to add the noloading attribute on images and carousels all over. And implement a blanket CSS Placeholder and enable the placeholder by just adding <div placeholder></div> in the component markup

camelburrito commented 6 years ago

@spacedino feel free to reopen

aghassemi commented 6 years ago
amp-img .amp-active {
display: none; 
}

should do it too.