search

ampproject / ampstart

AMP Start source code and templates .
https://ampstart.com/
Apache License 2.0
419 stars 152 forks source link

Land+See: instagram embed sizing broken #815

Closed ericlindley-g closed 6 years ago

ericlindley-g commented 6 years ago

Instagram embed sizing is broken on the article page (overlaps with other UI):

screen shot 2018-04-20 at 8 59 49 am

Related to resizing rule changes for amp-instagram? /cc @cathyxz @camelburrito

ericlindley-g commented 6 years ago

Looks like this happens only in the embedded context, FYI (on desktop ampstart.com, click the eye icon associated with the template to see)

camelburrito commented 6 years ago

which page is this on ?

ericlindley-g commented 6 years ago

Sorry — not on the home page for Land+See, but on the article page

camelburrito commented 6 years ago

This looks like something broke on instagram. We have not touched anything here for a while

nainar commented 6 years ago

Assigning this to myself. Seem like instagram isn't returning the height with the compensated padding-{top,bottom} values anymore. We currently compensate for that here. Removing our compensation fixes the issue. I'll submit a PR for this.

nainar commented 6 years ago

PR out here: https://github.com/ampproject/amphtml/pull/15105