search

ampproject / ampstart

AMP Start source code and templates .
https://ampstart.com/
Apache License 2.0
419 stars 152 forks source link

Added <amp-consent> stuff for GDPR #824

Closed morsssss closed 5 years ago

morsssss commented 6 years ago

I wasn't sure whether the components dir was the best place to stash the consent HTML and CSS. For example, www/partials contains other partials like footer.snip.html. But I liked the idea of putting the HTML and CSS in the same dir. Let me know if you want this moved elsewhere.

morsssss commented 6 years ago

@camelburrito , are you still working on this site? If so, can you review? If not, who should I ask?

camelburrito commented 6 years ago

ill review today

morsssss commented 5 years ago

Ok... how's this?

I left px values in two places, but everywhere else I've used CSS vars where I had them, and rem units where I didn't.

morsssss commented 5 years ago

thank you!

lmk if you want me to do the push to the appropriate environments.