ampproject / ampstart

AMP Start source code and templates .
https://ampstart.com/
Apache License 2.0
419 stars 152 forks source link

Update dependency mustache to v3 #834

Closed renovate-bot closed 4 years ago

renovate-bot commented 6 years ago

This PR contains the following updates:

Package Type Update Change
mustache devDependencies major 2.3.0 -> 3.1.0

Release Notes

janl/mustache.js ### [`v3.1.0`](https://togithub.com/janl/mustache.js/blob/master/CHANGELOG.md#​310--13-September-2019) [Compare Source](https://togithub.com/janl/mustache.js/compare/v3.0.3...v3.1.0) ##### Added - [#​717]: Added support .js files as views in command line tool, by [@​JEStaubach]. ##### Fixed - [#​716]: Bugfix for indentation of inline partials, by [@​yotammadem]. ### [`v3.0.3`](https://togithub.com/janl/mustache.js/blob/master/CHANGELOG.md#​303--27-August-2019) [Compare Source](https://togithub.com/janl/mustache.js/compare/v3.0.2...v3.0.3) ##### Added - [#​713]: Add test cases for custom functions in partials, by [@​wol-soft]. ##### Fixed - [#​714]: Bugfix for wrong function output in partials with indentation, by [@​phillipj]. ### [`v3.0.2`](https://togithub.com/janl/mustache.js/blob/master/CHANGELOG.md#​302--21-August-2019) [Compare Source](https://togithub.com/janl/mustache.js/compare/v3.0.1...v3.0.2) ##### Fixed - [#​705]: Fix indentation of partials, by [@​kevindew] and [@​yotammadem]. ##### Dev - [#​701]: Fix test failure for Node 10 and above, by [@​andersk]. - [#​704]: Lint all test files just like the source files, by [@​phillipj]. - Start experimenting & comparing GitHub Actions vs Travis CI, by [@​phillipj]. ### [`v3.0.1`](https://togithub.com/janl/mustache.js/blob/master/CHANGELOG.md#​301--11-November-2018) [Compare Source](https://togithub.com/janl/mustache.js/compare/v3.0.0...v3.0.1) - [#​679]: Fix partials not rendering tokens when using custom tags, by [@​stackchain]. ### [`v3.0.0`](https://togithub.com/janl/mustache.js/blob/master/CHANGELOG.md#​300--16-September-2018) [Compare Source](https://togithub.com/janl/mustache.js/compare/v2.3.2...v3.0.0) We are very happy to announce a new major version of mustache.js. We want to be very careful not to break projects out in the wild, and adhering to [Semantic Versioning](http://semver.org/) we have therefore cut this new major version. The changes introduced will likely not require any actions for most using projects. The things to look out for that might cause unexpected rendering results are described in the migration guide below. A big shout out and thanks to [@​raymond-lam] for this release! Without his contributions with code and issue triaging, this release would never have happened. ##### Major - [#​618]: Allow rendering properties of primitive types that are not objects, by [@​raymond-lam]. - [#​643]: `Writer.prototype.parse` to cache by tags in addition to template string, by [@​raymond-lam]. - [#​664]: Fix `Writer.prototype.parse` cache, by [@​seminaoki]. ##### Minor - [#​673]: Add `tags` parameter to `Mustache.render()`, by [@​raymond-lam]. ##### Migrating from mustache.js v2.x to v3.x ##### Rendering properties of primitive types We have ensured properties of primitive types can be rendered at all times. That means `Array.length`, `String.length` and similar. A corner case where this could cause unexpected output follows: View: { stooges: [ { name: "Moe" }, { name: "Larry" }, { name: "Curly" } ] } Template: {{#stooges}} {{name}}: {{name.length}} characters {{/stooges}} Output with v3.0: Moe: 3 characters Larry: 5 characters Curly: 5 characters Output with v2.x: Moe: characters Larry: characters Curly: characters ##### Caching for templates with custom delimiters We have improved the templates cache to ensure custom delimiters are taken into consideration for the cache. This improvement might cause unexpected rendering behaviour for using projects actively using the custom delimiters functionality. Previously it was possible to use `Mustache.parse()` as a means to set global custom delimiters. If custom delimiters were provided as an argument, it would affect all following calls to `Mustache.render()`. Consider the following: ```js const template = "[[item.title]] [[item.value]]"; mustache.parse(template, ["[[", "]]"]); console.log( mustache.render(template, { item: { title: "TEST", value: 1 } }) ); >> TEST 1 ``` The above illustrates the fact that `Mustache.parse()` made mustache.js cache the template without considering the custom delimiters provided. This is no longer true. We no longer encourage using `Mustache.parse()` for this purpose, but have rather added a fourth argument to `Mustache.render()` letting you provide custom delimiters when rendering. If you still need the pre-parse the template and use custom delimiters at the same time, ensure to provide the custom delimiters as argument to `Mustache.render()` as well. ### [`v2.3.2`](https://togithub.com/janl/mustache.js/blob/master/CHANGELOG.md#​232--17-August-2018) [Compare Source](https://togithub.com/janl/mustache.js/compare/v2.3.1...v2.3.2) This release is made to revert changes introduced in [2.3.1] that caused unexpected behaviour for several users. ##### Minor - [#​670]: Rollback template cache causing unexpected behaviour, by [@​raymond-lam]. ### [`v2.3.1`](https://togithub.com/janl/mustache.js/blob/master/CHANGELOG.md#​231--7-August-2018) [Compare Source](https://togithub.com/janl/mustache.js/compare/v2.3.0...v2.3.1) ##### Minor - [#​643]: `Writer.prototype.parse` to cache by tags in addition to template string, by [@​raymond-lam]. - [#​664]: Fix `Writer.prototype.parse` cache, by [@​seminaoki]. ##### Dev - [#​666]: Install release tools with npm rather than pre-commit hook & `Rakefile`, by [@​phillipj]. - [#​667], [#​668]: Stabilize browser test suite, by [@​phillipj]. ##### Docs - [#​644]: Document global Mustache.escape overriding capacity, by [@​paultopia]. - [#​657]: Correct `Mustache.parse()` return type documentation, by [@​bbrooks].

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.



Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

forking-renovate[bot] commented 4 years ago

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 3.x releases. However, if you upgrade to 3.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.