search

ampproject / ampstart

AMP Start source code and templates .
https://ampstart.com/
Apache License 2.0
419 stars 152 forks source link

Fix Validation Error on example #874

Closed eduardogoncalves closed 5 years ago

eduardogoncalves commented 5 years ago

Closes #873

eduardogoncalves commented 5 years ago

/ping @torch2424

eduardogoncalves commented 5 years ago
  1. From the diff, I can tell that I think your editor did a lot of "auto formatting" of all the indentation and things. I forgot if this project has a linter, but if it does, can you run it to undo the whitespace / tabbing changes?
  2. I also noticed some of the classes on the elements have been changed around. Could you explain why they were changed? And do you think they should/could go in another PR?

Sorry, I just copy&paste from here: https://www.ampstart.com/render/footer.amp

torch2424 commented 5 years ago

@eduardogoncalves Oh no worries at all! If anything, would you mind trying to preserve the formatting, and just editing from the source directly?

Or you know what it might be, if your fork up to date with out master? 🤔

Super open to working with you on this! 😄 👍