search

ampproject / bentojs.dev

Bento Website
Apache License 2.0
49 stars 9 forks source link

Separate {% endexample %} tags from code blocks #161

Closed ilyaspiridonov closed 2 years ago

ilyaspiridonov commented 2 years ago

The closing {% endexample %} tags are currently placed on the same line as closing fenced code block tags (```). While Eleventy seems to render pages correctly, this still results in incorrect parsing of the markdown files by translation platforms (and by GitHub - see screenshot). This PR adds extra line breaks to separate the {% endexample %} tags from code blocks so we can correctly parse the files for translation.

Screenshot 2022-01-05 at 17 59 33

ilyaspiridonov commented 2 years ago

@patrickkettner FYI

ilyaspiridonov commented 2 years ago

These docs are imported from the amphtml repo and the endexample tags are injected automatically. The line space needs to be added here: https://github.com/ampproject/bentojs.dev/blob/main/gulpfile.js/importDocs.js#L40

@sebastianbenz Ah, got it, thanks! Added another commit to address that. Looks like this is not something I can test locally, so can you PTAL?