Open ampprojectbot opened 2 years ago
@jridgewell You most recently touched this stacktrace on Dec 7 in https://github.com/ampproject/amphtml/pull/37144, would you mind taking a look? Appeared in Beta
A duplicate error report was linked to this issue (link)
A duplicate error report was linked to this issue (link)
My change couldn't have caused this. And, it's been in production since at lease May 2021.
@ampproject/wg-stories
A duplicate error report was linked to this issue (link)
A duplicate error report was linked to this issue (link)
My guess is this error is hapening because getAmpDoc().onVisibilityChanged
is triggered before AmpStory.layoutStory
on layoutCallback
, given that the visibility changes are being listened on the buildCallback() -> initializeListeners()
Details
Error report: link First seen: Dec 10, 2021 Frequency: ~ 565/day
Stacktrace
Notes
@rcebulko
modifiedsrc/core/data-structures/signals.js:90-90
in #34367 (May 14, 2021)@rsimha
modifiedsrc/service/ampdoc-impl.js:758-759
in #21212 (May 16, 2019)@jridgewell
modifiedsrc/service/ampdoc-impl.js:619-633
in #37144 (Dec 7, 2021)@rsimha
modifiedsrc/service/viewer-impl.js:605-608
in #21212 (May 16, 2019)@lannka
modifiedsrc/service/viewer-impl.js:749-749
in #6191 (Nov 17, 2016)Seen in:
Possible assignees:
@jridgewell
,@lannka
/cc @ampproject/release-on-duty