Open ampprojectbot opened 3 years ago
This is a very high-frequency error, and the two links above are for the Android and iPhone versions respectively. Previously we saw an error like this in https://github.com/ampproject/amphtml/issues/25643, which was the result of the AMP Viewer failing to get local storage permission due to browser settings. That was handled by catching the error in ViewerStorageBinding
This error stems from the same place in messaging, and should be caught in history-impl.js
where the replaceHistory
message is sent
@ampproject/wg-viewers It looks like this is coming from HistoryBindingVirtual
in either replace
or updateFragment
. Is there a viewer capability check that might be missing in one of these spots? Alternately, is the source of this error known (such as a restricted browser permission setting), in which case it should be marked as an expected error?
@ampproject/wg-viewers This continues to be reported at a volume of 1.5~2 million / day, nearly four times the volume of the next most common error. Could you take a look at this?
@ericfs could this possibly be coming from Search?
Yes, this seems likely to be from Search.
@flaviori @seanjallen
A duplicate error report was linked to this issue (link)
A duplicate error report was linked to this issue (link)
Details
Error report: link, link 2 First seen: Apr 8, 2020 Frequency: ~ 551,283/day
Stacktrace
Notes
@rsimha
modifiedextensions/amp-viewer-integration/0.1/messaging/messaging.js:460-461
in #21212 (May 16, 2019)@fstanis
modifiedextensions/amp-viewer-integration/0.1/messaging/messaging.js:82-83
in #24797 (Oct 30, 2019)Seen in:
Possible assignees:
@fstanis
/cc @ampproject/release-on-duty