search

ampproject / error-reporting

Contains production error tracking issues.
Apache License 2.0
2 stars 5 forks source link

🚨 Error: Attempted to assign to readonly property. #3

Open ampprojectbot opened 4 years ago

ampprojectbot commented 4 years ago

Details

Error report: link First seen: Jul 23, 2020 Frequency: ~ 278/day

Stacktrace

Error: Attempted to assign to readonly property.
    at extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js:886:10
    at rtcResponse (extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js:873:30)

/cc @ampproject/release-on-duty

zhouyx commented 4 years ago

to @ampproject/wg-ads

calebcordry commented 4 years ago

I spot checked a few of the error urls and this seems like it might be a pub error:

<amp-ad data-multi-size="300x50,320x100,300x100" data-multi-size-validation="false"
  data-slot="/6280/Entrepreneur/mobile/AMP" height="50" json="&quot;finanzas,finanzas-de-negocios,cobertura&quot;"
  layout="fluid"
  rtc-config="{&quot;urls&quot;: [&quot;https://entrepreneur.amp.permutive.com/rtc?type=doubleclick&quot;]}"
  type="doubleclick" width="320"
  i-amphtml-layout="fluid" data-amp-slot-index="4" data-a4a-upgrade-type="amp-ad-network-doubleclick-impl"
  style="width: 320px; height: 0px;">

@jeffkaufman can you confirm that the json attribute is incorrectly set up here? If so we can maybe handle the error more gracefully.

calebcordry commented 4 years ago

Based on my limited understanding of https://github.com/ampproject/amphtml/blob/204676c7e1774f44a439ca85d296718ac2c95001/extensions/amp-ad-network-doubleclick-impl/amp-ad-network-doubleclick-impl-internal.md#supported-parameters it seems like the json attr should always contain kv pairs.