🚨 Error: Template failed: [object HTMLTemplateElement] [object HTMLDivElement]: y is not a function. (In 'y(e)', 'y' is null)

ampprojectbot commented 3 years ago

Details

Error report: link First seen: Jan 22, 2021 Frequency: ~ 525/day

Stacktrace

Error: Template failed:  [object HTMLTemplateElement] [object HTMLDivElement]: y is not a function. (In 'y(e)', 'y' is null)
    at element (node_modules/dompurify/src/purify.js:503:31)
    at currentNode (node_modules/dompurify/src/purify.js:837:64)
    at currentNode (node_modules/dompurify/src/purify.js:1186:28)
    at dirty (src/purifier/purifier.js:101:42)
    at extensions/amp-mustache/0.2/amp-mustache.js:158:44
    at render_ (extensions/amp-mustache/0.2/amp-mustache.js:125:26)
    at data (src/service/template-impl.js:88:32)

Notes

@fstanis modified src/purifier/purifier.js:41-117 in #26221 (Jan 10, 2020) @choumx modified extensions/amp-mustache/0.2/amp-mustache.js:158-158 in #26298 (Jan 10, 2020) @dvoytenko modified extensions/amp-mustache/0.2/amp-mustache.js:125-138 in #30226 (Sep 16, 2020) @dvoytenko modified src/service/template-impl.js:88-91 in #3682 (Jun 21, 2016)

Seen in:

01-23 Nightly (0412)

Possible assignees: @dvoytenko, @choumx

/cc @ampproject/release-on-duty

jridgewell commented 3 years ago

This affects iOS 9 only, and is caused by an change in DOMPurify, which we upgraded in https://github.com/ampproject/amphtml/pull/32090. @dvoytenko Do you think we should downgrade?

dvoytenko commented 3 years ago

I believe we explicitly do not support iOS9. Is there a strong reason to change that rule?

jridgewell commented 3 years ago

Yah, I think it's fine to mark as won't fix? Both AMP and DOMPurify don't consider Safari 9 a supported browser.

dvoytenko commented 3 years ago

I agree

ampproject / error-reporting