Closed ampprojectbot closed 3 years ago
/cc @dvoytenko This seems like it may be directly related to https://github.com/ampproject/amphtml/pull/32853
/cc reviewers @calebcordry @jridgewell for visibility since it looks like Dima is OOO atm
A duplicate error report was linked to this issue (link)
A duplicate error report was linked to this issue (link)
Investigating now. It only affects nightly, so if I can land a fix we should be ok.
This is a really fun cross-module private name mangling issue. We seem to have multiple copies of the registerTemplate_
function, each with a different name, in any binary using mustache.
Reverted the PR, so this should disappear. But I'm going to leave this open while I try to fix the real underlying issues so we can rollfoward.
Ugh. I saw that private registerTemplate_
. There's just no need for it to be private.
Details
Error report: link First seen: Feb 25, 2021 Frequency: ~ 452/day
Stacktrace
Notes
@dvoytenko
modifiedsrc/service/extensions-impl.js:339-352
in #32853 (Feb 24, 2021)@dvoytenko
modifiedsrc/service/extensions-impl.js:490-495
in #10992 (Aug 28, 2017)@renovate-bot
modifiedsrc/service/extensions-impl.js:489-489
in #27350 (Mar 30, 2020)Seen in:
Possible assignees:
@dvoytenko
/cc @ampproject/release-on-duty