search

ampproject / error-reporting

Contains production error tracking issues.
Apache License 2.0
2 stars 5 forks source link

🚨 Error: Cannot read property 'querySelectorAll' of undefined #69

Open ampprojectbot opened 3 years ago

ampprojectbot commented 3 years ago

Details

Error report: link First seen: Nov 24, 2020 Frequency: ~ 2,722/day

Stacktrace

Error: Cannot read property 'querySelectorAll' of undefined
    at querySelectorAll (extensions/amp-next-page/1.0/service.js:695:18)
    at toggleHiddenAndReplaceableElements (extensions/amp-next-page/1.0/service.js:358:13)
    at forEach (extensions/amp-next-page/1.0/service.js:357:7)
    at updateVisibility (extensions/amp-next-page/1.0/service.js:542:13)
    at callback (extensions/amp-next-page/1.0/visibility-observer.js:310:10)
    at updateRelativePos (extensions/amp-next-page/1.0/visibility-observer.js:109:19)
    at handler_ (src/service/position-observer/position-observer-worker.js:109:11)

Notes

@renovate-bot modified extensions/amp-next-page/1.0/service.js:695-695 in #27350 (Mar 30, 2020) @wassgha modified extensions/amp-next-page/1.0/service.js:358-358 in #26106 (Jan 13, 2020) @renovate-bot modified extensions/amp-next-page/1.0/service.js:356-357 in #27350 (Mar 30, 2020) @wassgha modified extensions/amp-next-page/1.0/service.js:541-545 in #26296 (Jan 23, 2020) @wassgha modified extensions/amp-next-page/1.0/visibility-observer.js:294-381 in #26778 (Apr 9, 2020) @wassgha modified extensions/amp-next-page/1.0/visibility-observer.js:109-109 in #26778 (Apr 9, 2020) @zhouyx modified src/service/position-observer/position-observer-worker.js:106-136 in #10813 (Sep 8, 2017)

Seen in:

Possible assignees: @wassgha, @zhouyx

/cc @ampproject/release-on-duty

rcebulko commented 3 years ago

@jridgewell I see the last change to amp-next-page was in https://github.com/ampproject/amphtml/commit/b2b920e90858c651c37985d9ef555115402f2047#diff-95df70e7313c7d3ea5b4cc3926fae883dbcb3d3e2ed913ee56bda94b26fad27e ; any guess if these are related? This is occurring pretty frequently

jridgewell commented 3 years ago

Nah, I'm not sure why this is popping up, but it's unrelated. This is running over this.pages_ which contains both Page and HostPage instances. Only HostPage has a .document. So any time we try to call this with a Page, we get an error.

ampprojectbot commented 2 years ago

A duplicate error report was linked to this issue (link)

ampprojectbot commented 2 years ago

A duplicate error report was linked to this issue (link)

ampprojectbot commented 2 years ago

A duplicate error report was linked to this issue (link)