search

ampproject / error-reporting

Contains production error tracking issues.
Apache License 2.0
2 stars 5 forks source link

🚨 Error: this.ca.toggleAttribute is not a function #93

Closed ampprojectbot closed 2 years ago

ampprojectbot commented 3 years ago

Details

Error report: link First seen: Apr 10, 2021 Frequency: ~ 1,984/day

Stacktrace

Error: this.ca.toggleAttribute is not a function
    at toggleAttribute (extensions/amp-story/1.0/amp-story-draggable-drawer.js:264:19)
    at onUIStateUpdate_ (extensions/amp-story/1.0/amp-story-draggable-drawer.js:212:11)
    at listener (extensions/amp-story/1.0/amp-story-store-service.js:551:6)
    at subscribe (extensions/amp-story/1.0/amp-story-draggable-drawer.js:209:23)
    at initializeListeners_ (extensions/amp-story/1.0/amp-story-page-attachment.js:298:10)
    at initializeListeners_ (extensions/amp-story/1.0/amp-story-draggable-drawer.js:187:9)
    at layoutCallback (src/custom-element.js:1625:50)
    at fn (src/core/data-structures/promise.js:82:12)
    at src/core/data-structures/promise.js:81:9

Notes

@processprocess modified extensions/amp-story/1.0/amp-story-draggable-drawer.js:263-264 in #33601 (Apr 2, 2021) @gmajoulet modified extensions/amp-story/1.0/amp-story-draggable-drawer.js:212-215 in #23696 (Aug 6, 2019) @gmajoulet modified extensions/amp-story/1.0/amp-story-store-service.js:549-552 in #14265 (Mar 27, 2018) @gmajoulet modified extensions/amp-story/1.0/amp-story-draggable-drawer.js:183-210 in #23696 (Aug 6, 2019) @gmajoulet modified extensions/amp-story/1.0/amp-story-page-attachment.js:298-299 in #23696 (Aug 6, 2019) @gmajoulet modified extensions/amp-story/1.0/amp-story-draggable-drawer.js:183-210 in #23696 (Aug 6, 2019) @jridgewell modified src/core/data-structures/promise.js:82-85 in #15143 (May 8, 2018) @renovate-bot modified src/core/data-structures/promise.js:81-81 in #27350 (Mar 30, 2020)

Seen in:

Possible assignees: @processprocess, @gmajoulet

/cc @ampproject/release-on-duty

rcebulko commented 3 years ago

@processprocess headerEl_ is defined as nullable here: https://github.com/ampproject/amphtml/blob/2106182132000/extensions/amp-story/1.0/amp-story-draggable-drawer.js#L100 It's then accessed without a check here: https://github.com/ampproject/amphtml/blob/2106182132000/extensions/amp-story/1.0/amp-story-draggable-drawer.js#L264 Would you mind taking a peek at this?

/cc @samouri This is an excellent example of an error that accurate type-checking can eventually prevent completely. WDYT about creating a label or #searchable tag of some sort to start marking these types of issues as something to point to when looking to allocate time on type-checking?

ampprojectbot commented 2 years ago

A duplicate error report was linked to this issue (link)

ampprojectbot commented 2 years ago

A duplicate error report was linked to this issue (link)

ampprojectbot commented 2 years ago

A duplicate error report was linked to this issue (link)

processprocess commented 2 years ago

Closed by #37420