search

ampproject / px-toolbox-php

Apache License 2.0
8 stars 4 forks source link

PHPCS and PHPStan failure issues in GitHub checks #12

Closed ediamin closed 2 years ago

ediamin commented 2 years ago

Bug Description

Currently for for some PHPCS and PHPStan issues the GH checks are failing in the PR. PHPCS issues are mostly related to blank line after opening braces and PHPStan issues are mostly related to the data type issue for PHP v8.0.

Expected Behaviour

No fail in PR checks.

Screenshots

PHPCS issues:

Screenshot 2022-01-24 at 6 03 28 PM

PHPStan issues:

Screenshot 2022-01-24 at 6 03 50 PM

PHP Version

No response

Library Version

main

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response