Rename the default branch of this repo from `master` to `main`

ampproject / samples

Apache License 2.0

444 stars 191 forks source link

Rename the default branch of this repo from `master` to `main` #285

Closed rsimha closed 3 years ago

rsimha commented 3 years ago

See https://github.com/ampproject/amphtml/issues/32195 for more details

morsssss commented 3 years ago

Thanks for creating this issue, @rsimha ! One of us will take care of it....

rsimha commented 3 years ago

@morsssss I just checked and noticed that this repo contains no hard-coded references to the default branch. Happy to do the renaming for you if you'd like.

morsssss commented 3 years ago

Oh, thanks! That was going to be my first step: a big grep.

Please feel free to rename this - or to wait for me to do it next week :)

rsimha commented 3 years ago

No hurry, next week is good. Will leave this to you. 👍

morsssss commented 3 years ago

It's next week, and I'm now taking a look at this!

Unfortunately I think I lack the permissions to change the default branch. Looks like I'd do this under the "Settings" menu - which doesn't appear for me.

Is that right? If so, do you have the power to grant me the privileges I'd need?

In any case I was proud to notice that I was the person with the most commits in this subrepo! (Though not, I will note, the most lines of code.)

rsimha commented 3 years ago

It's possible you need repo admin access (or org-wide admin access) for this. I'm not sure who normally grants this, but I just took care of the branch renaming. Edit: Looks like @pbakaus is admin of this repo.

Looks like there's no other CI config to update, so I think this issue can be closed.

morsssss commented 3 years ago

Thanks! That was quick ⚡️⚡️⚡️