search

ampproject / wg-amp4email

Responsible for the AMP4Email project. Facilitator: @nainar
Creative Commons Attribution 4.0 International
56 stars 14 forks source link

Discussion: AMP element limits #4

Open johnbarr opened 5 years ago

johnbarr commented 5 years ago

As discussed in the June 14 2019 WG meeting we would like to add element limits to the AMP validator.

In accordance with how other AMP validator changes are made we should begin restrictive and become more permissive over time. As such we propose the following AMP element limits which permit the vast majority of AMP4Email in Gmail today:

Element Proposed limit
amp-state 5
amp-form 20
amp-anim 200
amp-img 200
amp-list 20

Also we should combine amp-anim and amp-img limits together as they're basically the same element.

fstanis commented 5 years ago

  1. Is it fair to assume elements not listed here have no limits?

  2. Is there a "rule of thumb" to decide the limits we'll impose on new elements we add in the future? Or should this be strictly case by case basis?

johnbarr commented 5 years ago

  1. Correct.

  2. Limit elements which require a lot of resources to "reasonable" limits. Mostly network resources right now. You could also expect limits on other intensive AMP components which get added later (hypothetically amp-video, etc...).

dreamofabear commented 5 years ago

LGTM