search

amqp-node / amqplib

AMQP 0-9-1 library and client for Node.JS
https://amqp-node.github.io/amqplib/
Other
3.67k stars 474 forks source link

Commit defs #758

Open cressie176 opened 5 months ago

cressie176 commented 5 months ago

There are some good arguments for committing the generated lib/defs.js file

  1. the github actions will run from the same lib/defs.js that the maintainers use, and that will be published
  2. it will be easier for users to contribute
  3. amqplib can be depended on using a github url from package.json, making it easier to test forks/branches

I've also decided to include the amqp-rabbit-0.9.1.json specification. It's not necessary, but only a small increase to the overall package size and might prove useful for someone trying to understand why an operation is missing