amqp / rhea-promise

A promisified layer over rhea AMQP client
Apache License 2.0
30 stars 19 forks source link

Add cancellation support to all async operations #66

Closed ramya-rao-a closed 3 years ago

ramya-rao-a commented 4 years ago

Description

Brief description of the changes made in the PR. This helps in making better changelog

Few design discussions:

Reference to any github issues

ramya-rao-a commented 4 years ago

cc @richardpark-msft, @HarshaNalluru

chradek commented 4 years ago

I looked into why the CI is failing for this PR. It looks like the new tests don't set reconnect: false on the connections they create. When I ran the tests locally I found there were 2 timers hanging around related to rhea's built in reconnect logic. When I set reconnect to false for all the added tests those timers went away.

I didn't dig into exactly which tests were still allowing reconnects to occur, maybe there are some that don't explicitly close the connection so rhea attempts to reconnect.

ramya-rao-a commented 4 years ago

yay! Thanks for the hint @chradek! Tests are green now

HarshaNalluru commented 4 years ago

Please add changelog