search

amqp / rhea-promise

A promisified layer over rhea AMQP client
Apache License 2.0
30 stars 19 forks source link

updates rhea-promise to 2.0.0 to match rhea dependency being updated to 2.x #87

Closed chradek closed 3 years ago

chradek commented 3 years ago

Description

rhea has been updated to 2.x, so this PR updates rhea-promise to use rhea 2.x!

There was only one breaking change in rhea: deserializing timestamps as dates instead of numbers.

Since we're doing a major version bump of rhea-promise, I also updated AwaitableSender.send to move the optional positional arguments to the options argument.

ramya-rao-a commented 3 years ago

Now that we have a major version update allowing us to clean up APIs that would be breaking changes, can we do something about this: https://github.com/amqp/rhea-promise/pull/66#discussion_r464826879 and https://github.com/amqp/rhea-promise/pull/66#discussion_r464576913

ramya-rao-a commented 3 years ago

Also, what do we have to gain by having timeout configurable both at the sender and each send level in the AwaitableSender? Can we afford to have it only on the send operation?

chradek commented 3 years ago

Also, what do we have to gain by having timeout configurable both at the sender and each send level in the AwaitableSender? Can we afford to have it only on the send operation?

Sure! I think all it will mean is a few more changes to our client packages, but no issues with making this change.

chradek commented 3 years ago

Now that we have a major version update allowing us to clean up APIs that would be breaking changes, can we do something about this: #66 (comment) and #66 (comment)

Done.