Next version for search

abumq commented 7 years ago

We have five search managers

All of these are children of SearchManager, we need to use lucene indexes to write next version of these search managers for

abumq commented 7 years ago

some improvement points we may consider (or may leave some for this version)

single page for all type of searches with filter options (including complete redesign of UI)
live update results (this will be handy but may overload cpu)
web services based for future uses + to handle live updates

abumq commented 7 years ago

Some issues along the way so far

Bookmarks and label types - possible solution: load after search is complete (also consider this has to be as real time as possible)
Normalising audio data will be a big challenge as we have solo, series and audio notes

Some notes

Some searches are not properly stripped - use params from SearchManager ✓
Remove items list for "also found in" search to reduce payload ✓
Provide link to legacy search until live search is out of beta (this will be in side bar)
Also provide live search option from legacy search
10 pages max for desktop with 4 in front and 5 in back (+1 for current page) [Adapted from Google] ✓
Only display "Next" in paging for mobile UI [Adapted from Google] ✓
Increase live search delay from 250 to 800ms ✓
Split "Also found in" to 2 sections, "Also found in" (when we have found results under that context) and "Search in" (when we have no result) ✓
Remove nprogress during live search
Change REST web service URL to include core as url path ✓
Add "Taking too long, click here to retry" option when search took more than x seconds
Handle when response was empty or with errors ✓

abumq commented 7 years ago

Notes

amrayn / planner