search

amrfarid140 / bitrise-step-microsoft-teams-integration

MIT License
1 stars 10 forks source link

Images Section #30

Closed clayellis-cricut closed 3 years ago

clayellis-cricut commented 3 years ago

Resolves #29

This PR adds support for adding an optional images section to the message card with support for a single image.

I've never written Go before and I'm not sure how to write/run tests so I'd appreciate some feedback on this.

clayellis-cricut commented 3 years ago

This is what a message with an image attached looks like:

image
clayellis-cricut commented 3 years ago

@jamie1192 once this is merged do you think it would be okay to make a 2.1.0 release so this can be used right away?

jamieastley commented 3 years ago

Apologies I'll try and get to this some time today.

Usually the PRs for step releases take a day or two to get approved and merged into the steplib, so if you need this asap you could just use the git reference in your bitrise.yml (I'm on mobile so hopefully the formatting comes out okay)

- ? git::https://github.com/clayellis-cricut/bitrise-step-microsoft-teams-integration@cellis/image-section
        : inputs:
            - webhook: ...
clayellis-cricut commented 3 years ago

No worries! Good point, I'll just point to my branch for now and test it in the wild.

jamieastley commented 3 years ago

@clayellis-cricut There was an indentation error in the step.yml that I missed in review. I've made the fix and opened https://github.com/bitrise-io/bitrise-steplib/pull/3040 to publish 2.1.1 to StepLib, once that's merged you won't need the git reference in your workflow anymore.

clayellis-cricut commented 3 years ago

Thanks for fixing that and for working with me through all of those issues to get this merged. I appreciate your help!