amrisi / amr-guidelines

250 stars 87 forks source link

Dimensions #208

Open seanmacavaney opened 7 years ago

seanmacavaney commented 7 years ago

I am having trouble annotating a dimension. Here's the only example I could find:

... a 9 x 6 ft ape ...
(a / ape 
      :mod (t2 / tall 
            :domain (d / distance-quantity :quant 9 
                  :unit (f / foot))) 
      :ARG1-of (w2 / wide-02 
            :extent (d2 / distance-quantity :quant 6 
                  :unit (f2 / foot))))

This doesn't seem very robust to me: (1) there is inconsistency in the way each dimension component is annotated; (2) the components are not bundled together; and (3) it assumes each component has an independent description on its own.

It's not so clear how to make the above approach work with the following examples where length/width/height are ambiguous or unknown:

... the 10 by 18 foot kitchen ...
... it formed a 2.5 x 1.8 cm mass ...
... a 4 x 4 x 12 inch brick ...

I propose handling it like this instead:

(a / ape
      :extent (d / dimension
            :op1 (d2 / distance-quantity :quant 9
                  :unit (f / foot))
            :op2 (d3 / distance-quantity :quant 6
                  :unit (f2 / foot))))

You lose the labeling of width and height, but that was not explicit in the sentence to begin with. And in situations where it is, one could use :mod to label each component.

Thoughts?

nschneid commented 7 years ago

Maybe this calls for a dimension-entity type? Otherwise your solution looks good.

seanmacavaney commented 7 years ago

Another option is to use product-of, which seems reasonable (source: @purplatypus). But I think dimension-entity is more semantic.