amrisi / amr-guidelines

246 stars 87 forks source link

Reification, examples #259

Open jheinecke opened 1 year ago

jheinecke commented 1 year ago

Hi, I wonder whether there is an error in the documentation on reification: It is said just above the reification chart that:

But in the chart, domain and range for be-located-at-91 are ARG1 and ARG2 so shouldn't it rather be:

BTW, the line for :cause cause-01 ARG1 ARG0 is missing in the cart (am I right that for cause-01 the domain in ARG1 and the rage ARG0 and not the other way round. It looks like following the example above (or is the example wrong?):

nschneid commented 1 year ago

Hi, I wonder whether there is an error in the documentation on reification: It is said just above the reification chart that:

  • Read this chart as: x :Relation y = x :Domain-of (z / Reification :Range y)

  • For example: x :location y = x :ARG0-of (b / be-located-at-91 :ARG1 y)

But in the chart, domain and range for be-located-at-91 are ARG1 and ARG2 so shouldn't it rather be:

  • For example: x :location y = x :ARG1-of (b / be-located-at-91 :ARG2 y)

Well spotted! Would you mind opening a pull request?

BTW, the line for :cause cause-01 ARG1 ARG0 is missing in the cart (am I right that for cause-01 the domain in ARG1 and the rage ARG0 and not the other way round. It looks like following the example above (or is the example wrong?):

  • Instead of x :cause y, we have x :ARG1-of (c / cause-01 :ARG0 y).

According to this page, :cause is just a shortcut—the editor will automatically substitute it with cause-01. The guidelines say "the Editor automatically reifies" :cause. Maybe the Reification section should have a note explaining that shortcuts are omitted from the table.

jheinecke commented 1 year ago

OK, no problem ! I haven't seen the other page before, thanks for the link. Shouldn't the shortcuts be added to the documentation (notably for the domain/range information (i.e which ARGx is domain and which one is range)?

nschneid commented 1 year ago

The shortcuts don't appear in the data, so strictly speaking that information would only apply to annotators using the AMR Editor. Maybe there should be a separate table for the shortcuts.

jheinecke commented 1 year ago

OK, I'll only correct the error and leave the second table to you to avoid errors for the domain/range relations