Show joined players in waiting room

JoshWein commented 3 years ago

Describe the bug It should show players currently in the waiting room so it's easier to tell if all players have joined

Browser:

All

JoshWein commented 3 years ago

This seems like it should show up, I do see it when I test locally but not on the live version;

https://github.com/amritrau/shadow-hunters/blob/master/shadow-hunters/app.py#L452

amritrau commented 3 years ago

Hi @JoshWein -- thanks for flagging this! Hope you're enjoying the game otherwise. This is a strange one: I see it consistently when testing locally, but the "Other players in the room:" message only appears sometimes on the deployed site.

Given that we've previously seen issues around clients dropping and reconnecting, my initial suspicion that this reconnect guard might be the problem (cc @mlevatich, would love to hear your thoughts as well) https://github.com/amritrau/shadow-hunters/blob/eec181cbd8feaea6ed1fe10472c6ca3d1d72658c/shadow-hunters/app.py#L453-L454

mlevatich commented 3 years ago

It's not immediately apparent to me what's happening here, but I agree with your suspicion @amritrau – I should have some time in the next couple of days to look into it more and figure out what's going on.

amritrau / shadow-hunters

Show joined players in waiting room #233