search

amrlabib / react-timer-hook

React timer hook
https://www.npmjs.com/package/react-timer-hook
MIT License
515 stars 112 forks source link

react native install issues #84

Closed cainlevy closed 2 years ago

cainlevy commented 2 years ago

react-timer-hook lists react-dom as a peer dependency, and npm v7 installs peer dependencies by default. This makes clean react-native installs impossible, despite the tag on this repository.

Is react-dom a necessary dependency?

Is react-native supported?

cainlevy commented 2 years ago

According to https://github.com/amrlabib/react-timer-hook/search?q=react-dom, react-dom should probably be a dev dependency.

If this makes sense, would it be possible to get a quick patch release?