amromeo / api_r2020

API R Workshop 2020
MIT License
5 stars 5 forks source link

EDA review #23

Closed hermands closed 5 years ago

hermands commented 5 years ago

@amromeo Love the EDA exercises. Lot's of interesting ideas and teaching points in there.

My thoughts:

amromeo commented 5 years ago

thanks dan, really helpful doing some reworking here to smoothen out stringr loads with tidyverse

pcmathias commented 5 years ago

@amromeo You may have this lined up but I want to circle back to Dan's feedback about the definitions - particularly making the distinctions about test_name, component, and what charttime actually represents. From what I can tell charttime is associated with the collection time for the sample rather than the result time and answering your challenge question for your turn 3 requires a good understanding.

I found it a little confusing at first that the questions were below the code chunk. I think there is a question of how much we want to encourage true exploration vs. how much we want to present directed goals. If we are emphasizing explicit instruction (even without breaking things down by every step) it might be good to put the questions up front.

Also, I think 5 min might be sufficient for your turn 2.

Overall it looks good and should make for a very interactive session!

pcmathias commented 5 years ago

Also, other quick thought: would rephrase challenge for your turn 4 to the middle 95 percent of hemoglobin rather than the reference range since this is not a normal population. I'm being nitpicky but I think that makes it clearer.