amrox / asdf-pyapp

A generic Python Application plugin the asdf version manager.
MIT License
60 stars 8 forks source link

Fix #12: ansible-base not working #14

Closed amrox closed 2 years ago

amrox commented 2 years ago

The version check for the legacy pip resolver was slightly off. It was "> 20" but it should have been ">=20".

Note, probably should revisit how versions are listed. Relying on side-effects from pip seems brittle.

May solve #12

amrox commented 2 years ago
❯ ./bats/bin/bats integration-tests.bats
 ✓ install with system python no asdf
 ✓ install with system python via asdf
 ✓ install with asdf python 3.8.10
 ✓ install with asdf python 3.5.10 system python 3.6
 ✓ install with asdf python 3.5.10 no system python3
 ✓ check latest with pip version 19.3
 ✓ check latest with pip version 20.0
 ✓ check latest with pip version 20.1
 ✓ check latest with pip version 20.2
 ✓ check latest with pip version 20.3
 ✓ check latest with pip version 21.3
 ✓ check $ASDF_PYAPP_DEFAULT_PYTHON_PATH works
 ✓ install with local python in direnv
 ✓ install with python plugin integration
 ✓ install with python plugin integration without python plugin installed
 ✓ install with asdf direnv no shims no global python
 ✓ install with asdf direnv no shims with global python
 ✓ check ASDF_PYAPP_VENV_COPY_MODE=1
 ✓ check app ansible latest
 ✓ check app awscli latest
 ✓ check app awsebcli latest
 ✓ check app aws-sam-cli latest
 - check app black latest (skipped)
 ✓ check app black 21.5b2
 ✓ check app conan latest
 ✓ check app doit latest
 ✓ check app flake8 latest
 ✓ check app hy latest
 ✓ check app meson latest
 ✓ check app mypy latest
 ✓ check app pipenv latest
 ✓ check app salt latest
 ✓ check app sphinx latest

33 tests, 0 failures, 1 skipped

asdf-pyapp/test on  issue/12-ansible-base-not-working 
❯ git rev-parse --short HEAD
d42b324