Open GoogleCodeExporter opened 9 years ago
Just tested this and it works for me - thanks!
Original comment by aaron.b...@gmail.com
on 7 Dec 2013 at 7:10
In patch form against the dat.gui repo this is:
diff --git a/src/dat/controllers/NumberController.js
b/src/dat/controllers/NumberController.js
index a589bf4..294e36c 100644
--- a/src/dat/controllers/NumberController.js
+++ b/src/dat/controllers/NumberController.js
@@ -122,6 +122,8 @@ define([
*/
step: function(v) {
this.__step = v;
+ this.__impliedStep = v;
+ this.__precision = numDecimals(v);
return this;
}
Original comment by aaron.b...@gmail.com
on 7 Dec 2013 at 7:10
Completely forgot about this issue. Thanks for trying it. Are you going to
submit the patch?
Original comment by ianballa...@turbulenz.biz
on 8 Dec 2013 at 12:12
Couldn't find guidance on how to submit, there aren't pull requests. Any ideas?
Original comment by aaron.b...@gmail.com
on 8 Dec 2013 at 6:02
Yeah, sorry not quite sure what the process is. I suppose you could ask one of
the owners.
Original comment by ianballa...@turbulenz.biz
on 9 Dec 2013 at 10:24
Got hold of one of the owners on twitter:
https://twitter.com/jonobr1/status/410213149543911424
jonobr1:
@airburst you are absolutely correct on that! My apologies. I'll get this
squared away in the next couple of days. Hold tight!
Original comment by aaron.b...@gmail.com
on 10 Dec 2013 at 1:21
Good news, it's back on github at https://github.com/dataarts/dat.gui
jonobr1 (@jonobr1) tweeted at 7:01 PM on Wed, Dec 18, 2013:
@airburst sorry for the delay. Github and Google Code are now mirrors and all
issues and Pull Requests will be redirected to Github.
Original comment by aaron.b...@gmail.com
on 19 Dec 2013 at 1:38
Pull request at https://github.com/dataarts/dat.gui/pull/31
Original comment by aaron.b...@gmail.com
on 19 Dec 2013 at 1:55
Now accepted and applied to codebase. Won't appear in the main js file until
they build.
https://github.com/dataarts/dat.gui/commit/1cb6eca274eae229915f386b7798ea19cf2a0
217
Original comment by aaron.b...@gmail.com
on 19 Dec 2013 at 2:21
Original issue reported on code.google.com by
ianballa...@turbulenz.biz
on 20 Feb 2013 at 5:48