search

amsam0 / voicechat-discord

A mod and plugin to make a bridge between Simple Voice Chat and Discord to allow for players without the mod to hear and speak.
https://modrinth.com/mod/simple-voice-chat-discord-bridge
MIT License
24 stars 7 forks source link

Allow using DiscordSRV API to make VCs more secure and make a lobby for when no players are nearby #35

Open TomSipsOnCurry opened 8 months ago

TomSipsOnCurry commented 8 months ago

So, doing /dvc start is a bit clanky and insecure. For instance, you could do /dvc start and someone else could join the voice chat.

My proposed solution is to add an optional toggle to access discordSRV's linked accounts API. This way all you would have to do is join the VC, and then it'll know which mc player it is. No need for /dvc start or /dvc stop

amsam0 commented 8 months ago

That could work, however, I am not sure how to do error handling. Suppose someone with the mod joins. How do we tell them that we can't make an audio sender? Users would have to give the bot permissions to disconnect players from the VC.

I think #23 is a better solution to this problem. I could also add functionality to disconnect users who join the VC but aren't linked to the person who did /dvc start.

TomSipsOnCurry commented 8 months ago

Im am not sure which mod you are referring to. TO issue the limitation due to the audio sender, like you said disconnecting the player would be the better option.

TomSipsOnCurry commented 8 months ago

I accidently closed the issue

TomSipsOnCurry commented 8 months ago

I got an awesome idea, so basically there's a lobby, whenever no one is near a Player A (who uses discord), they get moved to the lobby. However when they get near another player with SVC, they get moved to the next available VC. If there is no available VCs they get notified about it in MC. This way people will only hog ontu the VCs when it is being used.

amsam0 commented 8 months ago

Im am not sure which mod you are referring to. TO issue the limitation due to the audio sender, like you said disconnecting the player would be the better option.

Audio senders are what we use to make a player talk using audio from discord. They do not work if the player has SVC installed on their client

I got an awesome idea, so basically there's a lobby, whenever no one is near a Player A (who uses discord), they get moved to the lobby. However when they get near another player with SVC, they get moved to the next available VC. If there is no available VCs they get notified about it in MC. This way people will only hog ontu the VCs when it is being used.

This could work, could you make another issue for it? Also FYI, it's unlikely that I will be implementing this anytime soon.

TomSipsOnCurry commented 8 months ago

Audio senders are what we use to make a player talk using audio from discord. They do not work if the player has SVC installed on their client

For the lobby, option they just wont get moved to the VC.

This could work, could you make another issue for it? Also FYI, it's unlikely that I will be implementing this anytime soon.

Ill just rename this issue, cause they go hand in hand. Its a solution to a solution.