amsam0 / voicechat-discord

A mod and plugin to make a bridge between Simple Voice Chat and Discord to allow for players without the mod to hear and speak.
https://modrinth.com/mod/simple-voice-chat-discord-bridge
MIT License
24 stars 8 forks source link

SVC Plug Icon showing when discord user connects #46

Closed BerryBlu closed 6 months ago

BerryBlu commented 6 months ago

Whenever /dvc start is used and a bot is connected, players using the svc mod will receive the plug icon in the bottom left hand and their client will no longer be able to voice chat.

To Reproduce Steps to reproduce the behavior:

  1. Use /dvc start
  2. have a player with svc installed
  3. their voice chat will no longer work (/voicechat test yields "client not connected" message)

Expected behavior Voice chat works like normal

Screenshots If applicable, add screenshots to help explain your problem.

Logs at java.lang.Thread.run(Thread.java:840) ~[?:?] 04.05 20:54:54 [Server] INFO Caused by: de.maxhenkel.voicechat.concentus.OpusException: An error occurred during decoding: corrupted stream 04.05 20:54:54 [Server] INFO at de.maxhenkel.voicechat.concentus.OpusDecoder.decode(OpusDecoder.java:699) ~[voicechat-fabric-1.20.4-2.5.12%20(2).jar:?] 04.05 20:54:54 [Server] INFO at de.maxhenkel.voicechat.plugins.impl.opus.JavaOpusDecoderImpl.decode(JavaOpusDecoderImpl.java:44) ~[voicechat-fabric-1.20.4-2.5.12%20(2).jar:?] 04.05 20:54:54 [Server] INFO ... 9 more 04.05 20:54:54 [Server] JDA AudioConnection Guild: 1233934101216759940 Receiving Thread/ERROR [voicechat] Failed to dispatch event 'MicrophonePacketEventImpl' 04.05 20:54:54 [Server] INFO java.lang.RuntimeException: Failed to decode audio 04.05 20:54:54 [Server] INFO at de.maxhenkel.voicechat.plugins.impl.opus.JavaOpusDecoderImpl.decode(JavaOpusDecoderImpl.java:47) ~[voicechat-fabric-1.20.4-2.5.12%20(2).jar:?] 04.05 20:54:54 [Server] INFO at de.maxhenkel.vcinteraction.Plugin.onMicPacket(Plugin.java:88) ~[vcinteraction-fabric-1.20.4-1.0.6.jar:?] 04.05 20:54:54 [Server] INFO at de.maxhenkel.voicechat.plugins.PluginManager.dispatchEvent(PluginManager.java:136) ~[voicechat-fabric-1.20.4-2.5.12%20(2).jar:?] 04.05 20:54:54 [Server] INFO at de.maxhenkel.voicechat.plugins.PluginManager.onMicPacket(PluginManager.java:249) ~[voicechat-fabric-1.20.4-2.5.12%20(2).jar:?] 04.05 20:54:54 [Server] INFO at de.maxhenkel.voicechat.voice.server.Server.onMicPacket(Server.java:339) ~[voicechat-fabric-1.20.4-2.5.12%20(2).jar:?] 04.05 20:54:54 [Server] INFO at de.maxhenkel.voicechat.plugins.impl.audiosender.AudioSenderImpl.sendMicrophonePacket(AudioSenderImpl.java:90) ~[voicechat-fabric-1.20.4-2.5.12%20(2).jar:?] 04.05 20:54:54 [Server] INFO at de.maxhenkel.voicechat.plugins.impl.audiosender.AudioSenderImpl.send(AudioSenderImpl.java:66) ~[voicechat-fabric-1.20.4-2.5.12%20(2).jar:?] 04.05 20:54:54 [Server] INFO at dev.naturecodevoid.voicechatdiscord.audiotransfer.DiscordBot.handleEncodedAudio(DiscordBot.java:383) ~[voicechat-discord-fabric-2.1.1.jar:?] 04.05 20:54:54 [Server] INFO at dev.naturecodevoid.voicechatdiscord.shadow.jda.internal.audio.AudioConnection.lambda$setupReceiveThread$4(AudioConnection.java:411) ~[voicechat-discord-fabric-2.1.1.jar:?]

Versions (please complete the following information):

amsam0 commented 6 months ago

This is expected behavior, although a helpful message should appear. This plugin cannot be used by players that have SVC installed on their client.

amsam0 commented 6 months ago

Hm, actually, this might be a bigger issue. Let me know if having SVC disabled client side fixes it

BerryBlu commented 6 months ago

Yeah if I disable my SVC client side that would technically fix it. Is the bridge intended to communicate with the SVC mod?

BerryBlu commented 6 months ago

But that's only because it's SVC itself that is breaking, not DVC

amsam0 commented 6 months ago

Yes, it has to. But you can’t use DVC with SVC installed on your client (it has to be on the server though)

BerryBlu commented 6 months ago

Yeah but can other people? I have SVC without DVC and my friend has DVC without SVC and that's what's causing this issue. So does everyone have to only use DVC for this mod to work? or can some use SVC and others use DVC?

amsam0 commented 6 months ago

Server must have both DVC and SVC. People that want to use DVC should not have SVC installed on their client. DVC is a server sided mod, clients should not have it installed.

BerryBlu commented 6 months ago

Okay I think that makes sense