search

amsam0 / voicechat-discord

A mod and plugin to make a bridge between Simple Voice Chat and Discord to allow for players without the mod to hear and speak.
https://modrinth.com/mod/simple-voice-chat-discord-bridge
MIT License
24 stars 8 forks source link

Bot does not disconnect from voice channel #57

Closed DaddyRobLIVE closed 4 months ago

DaddyRobLIVE commented 4 months ago

Is your feature request related to a problem? Please describe. Yes, voice chat remains open even if they are no longer in use, this causes new users not to be able to create a voice chat room for them even though there are inactive rooms.

Describe the solution you'd like I'd like to have a bot killer timer available in the config, for example: inactivity-timer: 5m - this automatically destroys the proximity voice room if the player who started /dvc start has been offline for more than 5mins making the room available for other people's use.

Describe alternatives you've considered I've been reloading the plugin from time to time for new rooms to be generated but the problem with this is that active voice rooms will get disconnected.

Additional context None, thanks for your hard work!

amsam0 commented 4 months ago

Do the players run /dvc stop or leave the game, or do they just leave the voice channel while still playing the game? If they are still playing ask them to run /dvc stop when they are done

DaddyRobLIVE commented 4 months ago

Most players won't bother typing /dvc stop. They will just leave the server.

My suggestion above would be a good way since it'll be a hassle to keep opening a voice room using /dvc start if you get disconnected. But having a disconnection timer is good to give them some time to reconnect to the call.

amsam0 commented 4 months ago

If they leave the server the bot should stop itself. If it doesn't, that's a bug

DaddyRobLIVE commented 4 months ago

Oh really? Well, that might be a bug then. I do like the feature that the bot remains so that just in case the player disconnected especially for mobile users they can just join the room and when they enter the server they're automatically connected to the voice chat. I hope you will consider this suggestion as connecting to Discord using a mobile phone and then playing on that same phone is very tedious.

amsam0 commented 4 months ago

So when a player using voice chat leaves the server, does the bot leave the voice channel?

DaddyRobLIVE commented 4 months ago

So when a player using voice chat leaves the server, does the bot leave the voice channel?

The bot remains.

amsam0 commented 4 months ago

Are there any logs after/before the player leaves?

DaddyRobLIVE commented 4 months ago

I will check the console for logs.

amsam0 commented 4 months ago

Fixed in 3.0.2.

Paper: https://modrinth.com/plugin/simple-voice-chat-discord-bridge/version/3.0.2 Fabric: https://modrinth.com/plugin/simple-voice-chat-discord-bridge/version/SxkFwimn

amsam0 commented 4 months ago

If the bug fix doesn't fix the issue with you, feel free to make a feature request with the information you said earlier.

DaddyRobLIVE commented 4 months ago

Got it. I will check.