search

amsam0 / voicechat-discord

A mod and plugin to make a bridge between Simple Voice Chat and Discord to allow for players without the mod to hear and speak.
https://modrinth.com/mod/simple-voice-chat-discord-bridge
MIT License
24 stars 7 forks source link

Updated to 1.21.3 #75

Open AlexDerProGamer opened 1 week ago

AlexDerProGamer commented 1 week ago

I updated all dependecies to 1.21.3 and fixed the issue that appeared after doing so. I only tested the project as a fabric mod (not paper plugin) and I'm unsure if Bukkit.getEntity(nmsEntity.getUUID()); (nmsEntity.getBukkitSender(null); was removed) works. I also didn't manage to run cargo build on the core directory because cmake threw an error, so i copied the natives from the 3.0.5 version (from modrinth) to my built test mod.

If there's something that I forgot or does not work correctly let me know! Great mod/plugin btw, keep it up!

AlexDerProGamer commented 1 week ago

the mod didn't work on fabric 1.21.3 and threw an exception i will check if the updated code works on all older versions (fabric and paper)

amsam0 commented 1 week ago

What was the exception? I do not see the benefit of the paper changes and the fabric changes seem like they would have no effect.

Edit: if getBukkitSender was removed, we can try to find a replacement. Bukkit.getEntity won't work iirc

AlexDerProGamer commented 6 days ago

image the fabric method sendMessage() requires since the update a boolean value for the overlay option (i think they mean the text over the hotbar, not sure though)

amsam0 commented 6 days ago

The overlay argument isn't optional?

AlexDerProGamer commented 6 days ago

it looks like, it's not

amsam0 commented 5 days ago

That won't work with earlier versions then. Either we need an alternative (maybe there's a sendMessage function in another type that doesn't have the overlay argument) or use reflection on older version