amsbr / OctoPrint-EEPROM-Marlin

OctoPrint-EEPROM-Marlin
15 stars 31 forks source link

Making changes and selecting SAVE does not auto-upload to EEPROM #23

Open OutsourcedGuru opened 6 years ago

OutsourcedGuru commented 6 years ago

Version: 1.2.1

What I did:

I visited the Settings screen, selected the Home offset tab, noted the existing Z Axis value. I changed this in the interface by -0.10 and pressed the Save button in the bottom-right corner. The Settings dialog went away.

Re-visiting the Settings screen, I note that the Z Axis setting has the new value. Pressing the Load button brings back the former value, suggesting that it wasn't saved to the EEPROM. Presumably, it was only saved to OctoPrint's internal settings perhaps.

What I expected:

Given the name of the plugin, I expected this activity to automatically upload/write this change to the EEPROM when I press the Save button.

What I have to do each time

I have to then visit the Settings dialog once to set/save. I then have to revisit the page to press the Upload button as well.

Suggestion

Honestly, given that this is an EEPROM editor and not an OctoPrint Internal Values Editor, if it were me, I'd upload-on-save.