amsbr / OctoPrint-EEPROM-Marlin

OctoPrint-EEPROM-Marlin
15 stars 31 forks source link

Only info tab shows for 1.1.9 Bugfix #41

Open fcollingwood opened 5 years ago

fcollingwood commented 5 years ago

None of the settings tabs show for 1.1.9 Bugfix

Is this being maintained? There's an awful lot of open issues and bugs that date back quite some time screen shot 2019-01-23 at 3 06 47 pm

JBFUK commented 5 years ago

Same issue with Marlin 1.1.8; perhaps it's the OctoPrint version?

Akegata commented 5 years ago

I have the same issue in the 2.0 bugfix release of Marlin, so OctoPrint version sounds like a likely commonality. I'm running 1.3.10.

Akegata commented 5 years ago

If you still have an issue with this, I apparently "fixed" it for me by changing the Z probe offset in the terminal (M851 Z-1.2), that somehow triggered something that made the EEPROM plugin work again.

barnold96 commented 5 years ago

Interesting! I've been having a few issues and also ran into this today. After making changes to a section of the configuration.h file, One error went away, but this one arose. I changed the following: //

define EEPROM_SETTINGS // Enable for M500 and M501 commands //BA_CHANGE

//#define DISABLE_M503 // Saves ~2700 bytes of PROGMEM. Disable for release!

define EEPROM_CHITCHAT // Give feedback on EEPROM commands. Disable to save PROGMEM. //BA_CHANGE

// // Host Keepalive // // When enabled Marlin will send a busy status message to the host // every couple of seconds when it can't accept commands. // //#define HOST_KEEPALIVE_FEATURE // Disable this if your host doesn't like keepalive messages //BA_CHANGE //#define DEFAULT_KEEPALIVE_INTERVAL 2 // Number of seconds between "busy" messages. Set with M113. //BA_CHANGE //#define BUSY_WHILE_HEATING // Some hosts require "busy" messages even during heating //BA_CHANGE

When I attempted to check the eeprom settings, I, too, had only the INFO button. Just for the heck of it, I clicked the LOAD button and nothing happened, Then, I clicked the UPLOAD button and all the headings appeared! Don't ask me how - just reporting what I saw.

thoscut commented 5 years ago

Disabling EEPROM_CHITCHAT can cause this issue, as Marlin doesn't return a request result as expected by the plugin.

leftover commented 5 years ago

Sequence: M501 M500 worked for me. (EEPROM reset)

ghost commented 4 years ago

Hello guys,

I have now exactly these same problem. With Marlin 2.0.X from June - everything works perfectly fine. But when I upgrade Marlin to the newest version available on GitHub - I don't have "Advanced" tab in EEPROM editor.

Do You know why this happens? When I am getting back to this version from June - "advanced" tab (and every other tab) are there.

Thanks for help.

SVLoneStar commented 4 years ago

@TarruTarru I have the same issue and after looking into the code of the EEPROM plugin it seems that the format for certain messages was changed within Marlin, so that the plugin does no longer recognize them.

I believe the issue to be in line 23 of eeprom_marlin.js (which, from its code comments, is dated from July 2015). There it says

self.eepromM851RegEx = /M851 ([Z])(.*)/;

I replaced this by

self.eepromM851RegEx = /(M851.*)([Z])(.*)/;

I checked this in https://regex101.com/, and it seems to match the Z offset correctly. After downloading the plugin's ZIP, Imodified the file OctoPrint-EEPROM-Marlin-master\octoprint_eeprom_marlin\static\js\eeprom_marlin.js (as shown above) and re-installed the plugin. Now, the Advanced tab is visible, but the value is not (yet) filled...digging deeper... Any ideas welcome...

EDIT: HA, got it! The lines 253 and 254 currently read origValue: ((restoreBackup) ? '' : match[2]), value: match[2],

Due to the modified RegEx, they need to read the third and no longer the second element of the RegEx, so make them look like this:

origValue: ((restoreBackup) ? '' : match[3]), value: match[3],

Maybe again modifying the M851 RegEx above would make this second modification unneccessary...however, I am no RegEx enthusiast and just happy to have found this dirty workaround.

EDIT 2: After playing around with this for ~2 hours, I found a fork of the Marlin EEPROM plugin that claims to include all required adjustments for 2.0.x at https://github.com/Ketchu13/OctoPrint-EEPROM-Marlin

Just installed this by using the URL https://github.com/Ketchu13/OctoPrint-EEPROM-Marlin/archive/master.zip from OctoPrint's Plugin Manager...as said, this pugin claims to fix the incompatibilities between the EEPROM plugin and Marlin 2.0.x - however, I still had to apply the changes to the M851 RegEx and the matching element (3 instead of 2) as described above to have the Advanced tab visible...

It looks to me like current Marlin versions do no longer report the version of Marlin in the firmware request string...at least on my machine, M115 just looks like

FIRMWARE_NAME:Marlin bugfix-2.0.x (GitHub) SOURCE_CODE_URL:https://github.com/MarlinFirmware/Marlin PROTOCOL_VERSION:1.0 MACHINE_TYPE:3D Printer EXTRUDER_COUNT:1 UUID:11111111-2222-3333-4444-555555555555, while the OctoPrint documentation states that it reads the firmware's version from a 'response line' looking like

FIRMWARE_NAME:Some Firmware Name FIRMWARE_VERSION:1.2.3 PROTOCOL_VERSION:1.0

As you can see, the response line from my current Marlin firmware does no longer contain a 'FIRMWARE_VERSION' statement...so, I'll just stick with my fix from above and leave this to sufficiently skilled OctoPrint developers...maybe this is just because we're using a beta (2.0.x) instead of a proper release which might again include a version number...who knows...