search

amsbr / OctoPrint-EEPROM-Marlin

OctoPrint-EEPROM-Marlin
15 stars 31 forks source link

[Feature Request] Python 3 Compatibility #51

Open Andy-ABTec opened 4 years ago

Andy-ABTec commented 4 years ago

Please add Python 3 Compatibility as outlined here.

jim-p commented 4 years ago

I haven't tested it yet, but it doesn't look like it should need much more than the extra markings to indicate compatibility as mentioned in the link above.

The only thing flagged by 2to3 is this line in octoprint_eeprom_marlin/__init__.py:

--- __init__.py (original)
+++ __init__.py (refactored)
@@ -1,5 +1,5 @@
 # coding=utf-8
-from __future__ import absolute_import
+
cp2004 commented 3 years ago

Picked this fix into my fork of the plugin, https://github.com/cp2004/OctoPrint-EEPROM-Marlin/

You can see what I am currently developing in the ticket here https://github.com/cp2004/OctoPrint-EEPROM-Marlin/issues/1

Will be trying to transfer the plugin repository to point to my fork in a weeks time, since it seems abandoned here. (7 days time, official notice period.)