search

amschaal / glims

3 stars 0 forks source link

Child "issues" retain the coloring of their parent #6

Open jfass opened 8 years ago

jfass commented 8 years ago

I replied to a comment that was a "closed" "issue" (so, colored green). For the reply, I selected "issue" but not "closed", which I assumed would change it to a red color. But it appeared green, apparently inheriting from the original comment.

Maybe this is OK. Maybe child comments (replies) should not be able to be issues / open (or closed) ... maybe new issues should be input as new original comments?

msettles commented 8 years ago

Adam and I talked about the replies inheriting the status of the parent, this seem logical for the use case I came up with. As far as your situation, might it be best to create a new issue?

From: Joseph Fass notifications@github.com Reply-To: amschaal/glims reply@reply.github.com Date: Tuesday, April 26, 2016 at 11:02 AM To: amschaal/glims glims@noreply.github.com Subject: [amschaal/glims] Child "issues" retain the coloring of their parent (#6)

I replied to a comment that was a "closed" "issue" (so, colored green). For the reply, I selected "issue" but not "closed", which I assumed would change it to a red color. But it appeared green, apparently inheriting from the original comment.

Maybe this is OK. Maybe child comments (replies) should not be able to be issues / open (or closed) ... maybe new issues should be input as new original comments?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

amschaal commented 8 years ago

I'm trying to figure out how to get CSS to address this.

At the moment, I've made it so that something that is "Closed" and an "Issue" will always be green, even if it under another issue that is not closed.

However, if an "Issue" is under a "Closed Issue", it does not appear red, as you'd expect.

It's sort of a delicate dance involving CSS priorities, and when it comes to CSS I've got two left feet.