search

amsd2 / Shopping-list-generator

Jupyter notebook using Spoonacular API to recommend healthy personalised recipes matching individual dietary requirements and create a weekly shopping list. Developed in collaboration with Stewart Buchan (https://github.com/stewartbuchan) as part of a Science to Data Science (S2DS) fellowship project
0 stars 0 forks source link

Unit conversions #1

Open stewartbuchan opened 7 years ago

stewartbuchan commented 7 years ago

There needs to be a sensible way of choosing which unit the ingredients should be when we output them to the user. For instance, milk should be in ml and butter in g but both are dairy. Right now, both are given in ml(?)

amsd2 commented 7 years ago

Is this not an API issue? I seem to remember that if milk and butter are given in cups (a volume unit) in Spoonacular, then we convert to mL - and it's difficult to convert to mass unit without knowing the density...

Although is this happens all the time for specific very common ingredients eg butter, I guess we could add an exception for this ingredient id and make sure we get butter density and always display in g?

Alice Durieux

PhD Candidate | Institute of Psychiatry, Psychology & Neuroscience | King’s College London

Medical researcher | Research in Real Life (RiRL) UK

LinkedIn profile: https://uk.linkedin.com/in/alice-durieux-43515253

-

On 27 October 2016 at 13:29, stewartbuchan notifications@github.com wrote:

There needs to be a sensible way of choosing which unit the ingredients should be when we output them to the user. For instance, milk should be in ml and butter in g but both are dairy. Right now, both are given in ml(?)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/amsd2/Shopping-list-generator/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ATkPqM-GaB4UD8KWKQVge9vNKnDdMREoks5q4JklgaJpZM4KiSfS .