search

amsehili / genRSS

genRSS generates an RSS 2.0 feed from media files in a directory
https://github.com/amsehili/genRSS
MIT License
125 stars 43 forks source link

require mutagen? #44

Closed maphew closed 1 year ago

maphew commented 1 year ago

Are there particular reasons to not simply make mutagen a requirement instead of optional?

Mutagen is cross platform and has no dependencies outide of the python standard library. Guaranteeing it's available would simplify setup process as well as the Readme doc. The change is very straightforward:

diff --git a/pyproject.toml b/pyproject.toml
index f2b7a5e..bb6caf1 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -5,5 +5,7 @@ requires = ["setuptools", "wheel"]
 name = "genRSS"
 version = "0.2.0"

+dependencies = ["mutagen"]
+
 [project.scripts]
 genRSS = "genRSS:main"
amsehili commented 1 year ago

Now mutagen and eyed3 are installed automatically. See commit 9decb5a7f07cfa167c2f5e8f7c1c8b16c4469101.