search

amsgames / laravel-shop

Laravel shop package
MIT License
479 stars 167 forks source link

laravel 5.2 incompatability #27

Open ITwrx opened 8 years ago

ITwrx commented 8 years ago

Not to rush you on updating for laravel 5.2 but i thought i'd post this for your reference.

FatalErrorException in LaravelShopProvider.php line 91: Call to undefined method Illuminate\Foundation\Application::bindShared()

Thanks

ujwaldhakal commented 8 years ago

change bindShared to singleton in laravel-shop/src/LaravelShopProvider/

ITwrx commented 8 years ago

Thanks for your help. i did do that after i posted this but there seemed to be further changes needed with laravel-shop elsewhere so i pulled off temporarily. are you successfully using laravel-shop with 5.2?

ujwaldhakal commented 8 years ago

no not in 5.2 are there more issues let me know?

ITwrx commented 8 years ago

added new issue #31

thanks

DigitalCoder commented 8 years ago

Laravel 5.2 /vendor/amsgames/laravel-shop/src/LaravelShopProvider.php

change this /*$this->app->bindShared('command.laravel-shop.migration', function ($app) { return new MigrationCommand(); });*/ with $this->app->singleton('command.laravel-shop.migration', function ($app) { return new MigrationCommand(); });

ujwaldhakal commented 8 years ago

This ain't gonna close better don't comment i am getting notification