search

amsgames / laravel-shop

Laravel shop package
MIT License
483 stars 166 forks source link

Laravel 5.2 compatible bindshared changed to singleton #28

Open ujwaldhakal opened 8 years ago

ujwaldhakal commented 8 years ago

a

fwartner commented 8 years ago

push

amostajo commented 8 years ago

Will push this changes tiday

fwartner commented 8 years ago

Check out my fork https://github.com/fwartner/laravel-shop https://github.com/fwartner/laravel-shop

Am 11.01.2016 um 15:57 schrieb Alejandro Mostajo notifications@github.com:

Will push this changes tiday

— Reply to this email directly or view it on GitHub https://github.com/amsgames/laravel-shop/pull/28#issuecomment-170578805.

bkuhl commented 8 years ago

It'd be great if this was merged in. Though if this fully supports Laravel 5.2 then the README.md should be updated to reflect it's for 5.2.

ujwaldhakal commented 8 years ago

Leave it admin doesnt want it to be merged :+1:

bkuhl commented 8 years ago

@fwartner Your fork doesn't give this repo credit for the original concepts behind the package in that it doesn't indicate it was forked from here.

You've also mentioned it's L5.2 compatible but haven't updated the README.md

ujwaldhakal commented 7 years ago

still no merge? wew