search

amsik / liquor-tree

Tree component based on Vue.js
MIT License
398 stars 94 forks source link

Very slow performance while calling setModel on Firefox compare to Chrome #106

Open hirenvadalia opened 5 years ago

hirenvadalia commented 5 years ago

Thanks for the wonderful component! :1st_place_medal:

But there is very slow performance while calling setModel (since data prop is not reactive) on Firefox compare to Chrome with the same number of items in the tree.

To reproduce run below code sandbox in chrome and firefox and see the time it reports to call setModel on tree: https://codesandbox.io/embed/n5xp7999yj

hirenvadalia commented 5 years ago

@amsik Any update on a fix for this or any workaround as this is really affecting me?

hirenvadalia commented 5 years ago

@amsik any update on this?

hirenvadalia commented 5 years ago

@amsik This issue is really affecting me. Do you have any plan to look into this and fix it?

amsik commented 5 years ago

Hi. I will check it on weekends.

hirenvadalia commented 5 years ago

@amsik Any update on this? did you get a chance to look into this?

amsik commented 5 years ago

Hi. It is VueJS specific issue. It adds Observable objects to each property. But my fix might help. Please check a new version.

hirenvadalia commented 5 years ago

@amsik thanks will test and update you on the fix.