search

amsul / pickadate.js

The mobile-friendly, responsive, and lightweight jQuery date & time input picker.
http://amsul.ca/pickadate.js
MIT License
7.7k stars 1.01k forks source link

New release version breaking existing sites #1137

Closed gautam-in closed 5 years ago

gautam-in commented 5 years ago

The latest version publised for pick a date i.e. 3.6.0 is breaking the existing site code which was running on 3.5.6. Will recommend publishing the new code as a major release instead of minor release as it breaks existing code.

DanielRuf commented 5 years ago

Hi, in general we recommend using lockfiles.

What exactly is not working anymore? v4 and v5 are totally different and we will not republish this as major release.

holtkamp commented 5 years ago

@gautam-in looking at the commit https://github.com/amsul/pickadate.js/commit/4f9e01d3df01f45f99f2229aa47b72d7471e2baa, only some CSS optimizations were done? What is breaking for you?

@DanielRuf will the 3.6.0 release also "reach" CDNJS automatically?

DanielRuf commented 5 years ago

@gautam-in looking at the commit 4f9e01d, only some CSS optimizations were done? What is breaking for you?

You have to check all commits between this tag and the previous tag / release ;-)

DanielRuf commented 5 years ago

https://github.com/amsul/pickadate.js/compare/3.5.6...3.6.0

holtkamp commented 5 years ago

Aah, yeah, was a bit to quick. Sorry

DanielRuf commented 5 years ago

@holtkamp regarding a CDNJS update, see https://github.com/cdnjs/cdnjs/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

You can also use unpkg. https://unpkg.com/pickadate/

In general I would not recommend the usage of CDNs as they can have and often had outages and there are privacy issues and other things (would not work without an internet connection).

amsul commented 5 years ago

As mentioned in https://github.com/amsul/pickadate.js/issues/1138#issuecomment-473473523, v3.6.1 should resolve this issue.