search

amsul / pickadate.js

The mobile-friendly, responsive, and lightweight jQuery date & time input picker.
http://amsul.ca/pickadate.js
MIT License
7.7k stars 1.02k forks source link

Update picker.date.js #1162

Open Shimul22 opened 5 years ago

Shimul22 commented 5 years ago

Added a new option: setAsMaxYear (true or false), to decide whether user wants to add one/more years after current year or not

Shimul22 commented 5 years ago

If setAsMaxYear: true --> then the current year will be treated as the last year/max year (in the dropdown)

If setAsMaxYear: false (or not included) --> Then numberYears will be added after current year

This will solve #1161

DanielRuf commented 5 years ago

Hi @Shimul22,

Thanks for the PR.

Please update the title and commit message and provide some tests if possible.

Can you add this for v5? v3 is not actively developed anymore.

Shimul22 commented 5 years ago

@DanielRuf

Please update the title

Can you tell me what do mean by the title?

Can you add this for v5? v3 is not actively developed anymore

Version v5 means future origin?

DanielRuf commented 5 years ago

Update picker.date.js

This title / message is not sufficient. Please change it do describe your changes. See the other PRs.

DanielRuf commented 5 years ago

Version v5 means future origin?

Exactly. This is a full rewrite.