search

amsul / pickadate.js

The mobile-friendly, responsive, and lightweight jQuery date & time input picker.
http://amsul.ca/pickadate.js
MIT License
7.7k stars 1.02k forks source link

[BUG] `editable: true` makes picker never closes #1170

Closed HeiVask closed 5 years ago

HeiVask commented 5 years ago

Tested on latest version (3.6.2) on Chrome 74.0.3729.157.

It can be seen at https://amsul.ca/pickadate.js/time/#editable.

To reproduce, just pick on "Try me" input. The picker opens but never closes.

Here's a demonstration:

ezgif com-resize

DanielRuf commented 5 years ago

Hi @HeiVask,

3.6.3 is the latest release. See https://github.com/amsul/pickadate.js/releases/tag/3.6.3

Can you try this too and provide a codepen so we can reproduce this?

HeiVask commented 5 years ago

Hi 👋

I didn't notice about version. At https://amsul.ca/pickadate.js/ the download button still links to 3.6.2.

It seems the bug keeps there also in 3.6.3: https://codepen.io/heivask/pen/VOQMPX

DanielRuf commented 5 years ago

cc @amsul can you check the 3.6.3 release and link it on the website? I remember there was a similar issue.

DanielRuf commented 5 years ago

https://github.com/amsul/pickadate.js/compare/3.6.3...master

We need a new patch release @amsul. It works with the files from the current master branch. https://codepen.io/DanielRuf/pen/VOQyzm

amsul commented 5 years ago

Just shipped 3.6.4 and also updated gh-pages. It should be fine now 👍