search

amsul / pickadate.js

The mobile-friendly, responsive, and lightweight jQuery date & time input picker.
http://amsul.ca/pickadate.js
MIT License
7.7k stars 1.01k forks source link

suppress outline on the root picker element #997

Closed DanielRuf closed 6 years ago

DanielRuf commented 7 years ago

See https://github.com/Dogfalo/materialize/issues/4793

tomscholz commented 7 years ago

Maybe you could try to make the PR against the next branch

DanielRuf commented 7 years ago

@tomscholz does this make any difference? Because the current contributing file says that we should file PRs against the master branch and both branches have almost the same date when they were last updated.

See https://github.com/amsul/pickadate.js/blob/master/CONTRIBUTING.md

tomscholz commented 7 years ago

Did not see that. Sorry. Yes, I guess then it would make no difference

DanielRuf commented 6 years ago

Bump.

DanielRuf commented 6 years ago

@tomscholz do you think we should keep it there for keyboard users / a11y?

Or should this be done with what-input and other solutions?

tomscholz commented 6 years ago

Sorry for the delay :) I think this solution is great 👍

DanielRuf commented 6 years ago

Sorry for the delay :) I think this solution is great 👍

Thanks. For other solutions I suggest using https://github.com/ten1seven/what-input to apply the needed focus styles globally.