Several false-positives for Vic3 1.7.*

[dragon-archer]

• The localization key of a modifier type is simply the type itself, with no modifier_ prefix any more
• scope:law in can_impose scope under law definitions produces law_type instead of law (However, scope:law in ai_enact_weight_modifier indeed produces law, that is strange, but I've confirmed it under Debug Mode)
  • Reproduce steps: Start as Great Britain in Debug Mode, add Colonization technology for Kaurna, try to impose Colonial Exploitation for it and you can see the correct tooltip, then change scope:law to scope:law.type in the law definition & restart (or hot reload), you'll get thousands of error log complaining about wrong scope type

[dragon-archer]

Another two:

• The localization key of diplomatic action is also the action name itself, with no _name suffix
• diplomatic_pact_other_country(XXX) = YYY should accept 2 country scopes, instead of value scope

[amtep]

* The localization key of `diplomatic action` is also the action name itself, with no `_name` suffix

Hmm, it already is checked that way... but in addition to the action name itself, it checks for {key}_action_name and {key}_action_propose_name. I don't know where they're used in the UI but those keys are present for all vanilla actions.

* `diplomatic_pact_other_country(XXX) = YYY` should accept 2 country scopes, instead of value scope

Fixed in main :)

[amtep]

All fixed in 1.1.0, except for the diplomatic action one where I believe tiger is already correct.