amtgard / ORK3

Version 3 of the Online Record Keeper
Other
23 stars 12 forks source link

Yapo files included in project do not map to required project #107

Open jfefes opened 7 years ago

jfefes commented 7 years ago

config.php has the following lines:

require_once(DIR_LIB.'yapo/class.yapo_mysql.php');

require_once(DIR_LIB.'yapo/class.yapo.php');

require_once(DIR_LIB.'yapo/class.yapo_result.php');

yapo is not a directory within the ORK project. Instead, it looks like a Yapo2 project has been put there instead. This causes an error in startup.php in line 14, when the initial database connection is made:

$DB = new YapoMysql( DB_HOSTNAME, DB_DATABASE, DB_USERNAME, DB_PASSWORD );

However, the YapoMysql class in startup.php#14 is not a class that exists in the Yapo2 package.

While searching for yapo (https://github.com/zealotrunner/Yapo), it seems like these classes are not included in yapo either.

I'm not quite sure of the easiest fix for this. I cannot seem to get a fresh install of docker to work on a fresh fork of this project. If there is another place to get the required yapo files from? Would it be possible to set up these requirements in a package manager such as Composer?

esdraelon commented 7 years ago

The project is in a bit of flux. I cannot speak to Docker, since it is not a use case for production, but I will get HEAD fixed in the next week.

On Dec 16, 2016 9:03 PM, "James Fefes" notifications@github.com wrote:

config.php has the following lines:

require_once(DIR_LIB.'yapo/class.yapo_mysql.php');require _once(DIR_LIB.'yapo/class.yapo.php');requireonce(DIR LIB.'yapo/class.yapo_result.php');`

yapo is not a directory within the ORK project. Instead, it looks like a Yapo2 project has been put there instead. This causes an error in startup.php in line 14, when the initial database connection is made.

However, the YapoMysql class in startup.php#14 is not a class that exists in the Yapo2 package.

While searching for yapo (https://github.com/zealotrunner/Yapo), it seems like these classes are not included in yapo either.

I'm not quite sure of the easiest fix for this. I cannot seem to get a fresh install of docker to work on a fresh fork of this project. If there is another place to get the required yapo files from? Would it be possible to set up these requirements in a package manager such as Composer?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/amtgard/ORK3/issues/107, or mute the thread https://github.com/notifications/unsubscribe-auth/AHh_D1uQrfNbeDwXNXx84Tsn8IdvrHDoks5rI1D-gaJpZM4LPwaJ .

BenOvermyer commented 7 years ago

There has been a fair amount of project drift since the original Docker instructions were written. It's possible that they're no longer accurate.

Personally, before I took an indefinite hiatus from the project, I was planning on replacing Yapo with a more supported database ORM package. The work to replace Yapo with Doctrine or Eloquent, though, is pretty extensive.

jfefes commented 7 years ago

That's fair. I'm working on a sign in tool right now that allows a chancellor/PM to submit a csv/list to the ork as a batch job (on my end) and get back a completed/failed response.

Ultimately, i'm just looking to get access to a local/staging version of the app/database. I'm able to communicate with the live API without any issue right now, but I feel bad about sending test attendances to the production app.

esdraelon commented 7 years ago

James, I'll tie out with you on facebook.

Noah

On Dec 19, 2016 3:25 PM, "James Fefes" notifications@github.com wrote:

That's fair. I'm working on a sign in tool right now that allows a chancellor/PM to submit a csv/list to the ork as a batch job (on my end) and get back a completed/failed response.

Ultimately, i'm just looking to get access to a local/staging version of the app/database. I'm able to communicate with the live API without any issue right now, but I feel bad about sending test attendances to the production app.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/amtgard/ORK3/issues/107#issuecomment-268082857, or mute the thread https://github.com/notifications/unsubscribe-auth/AHh_D8j7hvQ63WZPpfhS3rdyY9dWsy1xks5rJvY1gaJpZM4LPwaJ .