amtgard / ORK3

Version 3 of the Online Record Keeper
Other
23 stars 11 forks source link

Correct Dues Issues #188

Closed esdraelon closed 3 years ago

esdraelon commented 6 years ago

https://github.com/amtgard/ORK3/issues/94 https://github.com/amtgard/ORK3/issues/113 https://github.com/amtgard/ORK3/issues/165 https://github.com/amtgard/ORK3/issues/167 https://github.com/amtgard/ORK3/issues/174

Remove treasury, create a dues paid table: dues_id mundane_id - player kingdom_id - dues paid to park_id - dues paid to created_on - record created at created_by - record created by dues_from - start date for dues terms - number of terms dues_until - last date dues are valid (may be null) dues_closed_from - if closed early, original termination date dues_for_life - boolean (dues for life)

By default, close dues when a player transfers between kingdoms. By default, close dues for all players at a park that transfers between kingdoms. Allow an option for holding dues during transfers.

Update report class with new dues table.

jrtaylor-com commented 3 years ago

By default, close dues when a player transfers between kingdoms. By default, close dues for all players at a park that transfers between kingdoms. Allow an option for holding dues during transfers.

Dues should always hold over really, aren't most kingdoms Non Profits? Technically transferring your credits to a different kingdom doesn't revoke your relationship with that organization. Bigger picture is that someone can and should be able to be a member of multiple kingdoms (orgs) unless there is a disassociation, or a membership requirement that requires physical residency, or unique membership

Thoughts?

jrtaylor-com commented 3 years ago

I think a column for "revoked" boolean would be useful as well

Glenalth commented 3 years ago

Locally, Transferring to another Kingdom ends your membership and voting rights with the kingdom.

kenwalker commented 3 years ago

I think there are people with random “dues paid forever” get really upset if it is not propagated. This is a higher level question that should be asked.

jrtaylor-com commented 3 years ago

When I say "hold over" I meant, they should not be "canceled" or "revoked" with the entity they paid toward. I think displaying dues in a situation like this would show what kingdom/park that dues entry is tied into.

Analogy: You pay rent for an apartment on Main Street. But you are moving to to the East side and have gotten an apartment there. You are paid up through the month on Main Street. Just because you dont sleep there doesn't give that apartment owner the right to change the locks until your lease runs out.

tzulah commented 3 years ago

I think there are people with random “dues paid forever” get really upset if it is not propagated. This is a higher level question that should be asked.

In my kingdom, dues paid for life is specifically tied to our kingdom ONLY. It is understood that dues paid do NOT transfer to any other kingdom. I think jrtaylor's comment is exactly relevant. Furthermore, if that player moves back to the original park, they should still be dues paid for life, I would think?

jrtaylor-com commented 3 years ago

Screen Shot 2021-04-15 at 1 38 24 PM

With this layout I am using, the records are maintained regardless of where they switch to and it's presented that way. Revoked records can be seen in the admin view. If a park changes kingdoms, the view will reflect their dues in both kingdoms and that can be seen visually